Don't chown when local-store is read-only#10916
Merged
roberth merged 1 commit intoNixOS:masterfrom Jun 17, 2024
Merged
Conversation
github-actions
bot
added
the
store
Member
|
We should move this down so it doesn't hide the warnings, however. |
If the local-store is using the read-only flag, the underlying filesystem might be read-only, thus an attempt to `chown` would always fail.
jmbaur
force-pushed
the
read-only-no-chown
branch
from
e503e9b to
de639ce
Compare
Member
|
@Ericson2314 This makes the command more fragile though, because it adds an irrelevant check and irrelevant error. Simple store reading operations should just work, even if the configuration can't build. |
Member
|
Oh, I misread |
roberth
approved these changes
Jun 17, 2024
Member
|
We don't have suitable testing infrastructure for this yet, so I'll open an issue for a regression test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
If the local-store is using the read-only flag, the underlying filesystem might be read-only, thus an attempt to
chownwould always fail.Context
Using local-overlay-store and read-only-local-store fails to work due to an attempt to
chownthe lower store's directory toroot:nixbldPriorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.