fix: warn and document when advanced attributes will have no impact d…#10884
Merged
roberth merged 2 commits intoNixOS:masterfrom Jun 24, 2024
Merged
Conversation
…ue to __structuredAttrs
github-actions
bot
added
documentation
with-tests
Member
|
👍 This will dovetail nicely with @haenoe's work :) |
roberth
force-pushed
the
tomberek.warn_structuredAttrs_advanced
branch
from
b0f6912 to
de3fd52
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Ericson2314
requested review from
Ericson2314,
edolstra,
fricklerhandwerk,
roberth and
thufschmitt
as code owners
Member
|
I think the TODOs are fine as future work, because they will be easier to do in conjunction with @haenoe's work. |
Ericson2314
approved these changes
Jun 24, 2024
lf-
pushed a commit
to lix-project/lix
that referenced
this pull request
Aug 7, 2024
…ue to __structuredAttrs Backport of NixOS/nix#10884. Change-Id: I82cc2794730ae9f4a9b7df0185ed0aea83efb65a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ue to __structuredAttrs
TODO
nix derivation addMotivation
Fix: #10856
Context
Clarify that the use of
__structuredAttrswill disable the effect of top-level derivation attributes.Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.