Skip to content

Comments

Query path infos (plural) and handshake version minimum for hydra#10749

Merged
Ericson2314 merged 1 commit intomasterfrom
serve-protocol-stuff-for-hydra
May 20, 2024
Merged

Query path infos (plural) and handshake version minimum for hydra#10749
Ericson2314 merged 1 commit intomasterfrom
serve-protocol-stuff-for-hydra

Conversation

@Ericson2314
Copy link
Member

Motivation

  1. Hydra currently queries for multiple path infos at once, so let us make a connection item for that.

  2. The minimum of the two versions should always be used, see Protocol version negotiation currently doesn't result in agreement #9584. (The issue remains open because the daemon protocol needs to be likewise updated.)

Context

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

1. Hydra currently queries for multiple path infos at once, so let us
   make a connection item for that.

2. The minimum of the two versions should always be used, see #9584.
   (The issue remains open because the daemon protocol needs to be
   likewise updated.)
@github-actions github-actions bot added the store Issues and pull requests concerning the Nix store label May 20, 2024
@Ericson2314 Ericson2314 enabled auto-merge May 20, 2024 22:04
@Ericson2314 Ericson2314 merged commit a57abbd into master May 20, 2024
@Ericson2314 Ericson2314 deleted the serve-protocol-stuff-for-hydra branch May 20, 2024 22:10
Ericson2314 added a commit to obsidiansystems/hydra that referenced this pull request May 20, 2024
Ericson2314 added a commit to NixOS/hydra that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

store Issues and pull requests concerning the Nix store

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant