Merged
Conversation
github-actions
bot
added
repl
8 tasks
Ericson2314
force-pushed
the
better-signals-interface
branch
from
1a1448b to
2edc3c9
Compare
puffnfresh
reviewed
Apr 4, 2024
| * some extra Unix-only interfaces. | ||
| * | ||
| * (The only reason everything about signals isn't Unix-only is some | ||
| * no-op definitions are provided on Windows to avoid excess CPP in |
Member
There was a problem hiding this comment.
Not present in this PR, that's coming later?
puffnfresh
reviewed
Apr 4, 2024
Member
There was a problem hiding this comment.
Appreciate the comment notes on this. Looks good.
This avoids some CPP and accidentally using Unix stuff in client code.
Ericson2314
force-pushed
the
better-signals-interface
branch
from
2edc3c9 to
50f621b
Compare
roberth
reviewed
Apr 5, 2024
| /** | ||
| * @note Does nothing on Windows | ||
| */ | ||
| static inline void setInterruptCheck(std::function<bool()> interruptCheck); |
Member
There was a problem hiding this comment.
GCC says
In file included from src/nix-collect-garbage/nix-collect-garbage.cc:2:
src/libutil/signals.hh:27:20: warning: ‘void nix::setInterruptCheck(std::function<bool()>)’ declared ‘static’ but never defined [-Wunused-function]
27 | static inline void setInterruptCheck(std::function<bool()> interruptCheck);
| ^~~~~~~~~~~~~~~~~
Member
Author
There was a problem hiding this comment.
Thanks, sorry about that!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This avoids some CPP and accidentally using Unix stuff in client code.
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.