Clean up env var logic in preparation for Windows#10400
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Apr 4, 2024
Merged
Clean up env var logic in preparation for Windows#10400Ericson2314 merged 1 commit intoNixOS:masterfrom
Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
8 tasks
thufschmitt
approved these changes
Apr 4, 2024
Member
thufschmitt
left a comment
thufschmitt
left a comment
There was a problem hiding this comment.
Small tidbits, looks good overall
It's a little weird we don't check the return status for these, but changing that would introduce risk so I did not. Co-authored-by: Théophane Hufschmitt <[email protected]>
Ericson2314
force-pushed
the
better-env-var
branch
from
8eb3a5f to
ef2d10f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#1320
Context
It's a little weird we don't check the return status for these, but changing that would introduce risk so I did not.
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.