Make SQLite busy back-off logic portable#10399
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Apr 4, 2024
Merged
Conversation
Use C++ standard library not Unix functions for sleeping and randomness. Suggested by @edolstra in NixOS#8901 (comment)
8 tasks
Member
🙈 |
Member
Author
|
I did the self-mege because I did the exact thing @edolstra requested in the other thread. It felt like he was the author and I was the reviewer --- I checked that this is in fact more portable. |
lf-
pushed a commit
to lix-project/lix
that referenced
this pull request
Feb 6, 2025
Use C++ standard library not Unix functions for sleeping and randomness. Also change the PRNG seed from `clock()` to `std::random_device` because there's no good reason not to and this avoids two threads seeding their PRNG the same. Upstream-PR: NixOS/nix#10399 Change-Id: I8424e7406366ea8e825d3e93dbb261ce60e3a37f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Use C++ standard library not Unix functions for sleeping and randomness.
Context
Suggested by @edolstra in #8901 (comment)
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.