I think ] and even ) on their own line with trailing commas for the last list item / argument would be preferred.

I think ] and even ) on their own line with trailing commas for the last list item / argument would be preferred.

the style isnt standard across the codebase, there doesnt seem to be anything to suggest which should be used.

the style isnt standard across the codebase, there doesnt seem to be anything to suggest which should be used.

For C++ we put the ) on the same line, but for { ... } initializer lists we always put the } on its own line. That would be the equivalent of [ ... ].

I love to see progress on this.

Just a small point: could you use the imperative mood instead of past tense in commit messages?
Nix, Nixpkgs and Git itself use it that way.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-04-03-nix-team-meeting-135/42962/1

@Ericson2314 is this stuck on style alone?

@roberth Yes, if that is even a blocker.

@Ericson2314 is this stuck on style alone?

style can be fixed trivially, waiting on consensus of whether to merge before investing more time :)

👍 from me.
@thufschmitt has approved of it too.

Based on the notes, while Eelco wasn't convinced, he didn't outright reject it, so I think we should try it. After all, the point of doing a part of the project first is that we can evaluate meson in practice.

sounds good, ill fix up the style issues and get the pr corrected.

Yes and now that mesonbuild/meson#13055 is merged, I think all style matters can squarely follow upstream recommendations, rather than me winging it :)