Factor out isRootUser function#10363
Merged
thufschmitt merged 1 commit intoNixOS:masterfrom Mar 30, 2024
Merged
Conversation
github-actions
bot
added
new-cli
8 tasks
puffnfresh
approved these changes
Mar 29, 2024
Member
puffnfresh
left a comment
puffnfresh
left a comment
There was a problem hiding this comment.
Much nicer. I'm not sure what the plan is for Windows but we can't have uid scattered throughout the code in any case.
thufschmitt
approved these changes
Mar 30, 2024
Member
Author
|
Yeah I am not sure what it will be for Windows either, but I also hope this function can be used less and less as special-casing root on Unix is not great either. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This helps with Windows porting
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.