Build system changes for MinGW support#10329
Merged
edolstra merged 3 commits intoNixOS:masterfrom Mar 27, 2024
Merged
Conversation
github-actions
bot
added
new-cli
Ericson2314
changed the title
Member
|
This seems to refer to a "unix" subdirectory that doesn't exist. |
Member
Author
Member
I agree with Eelco that referring to those in advance is a strange division of labor. |
We can build the dep and the our GC code is totally portable, but for some reason we get link errors saying `GC_throw_bad_alloc` is missing.
… `INLCUDE_$(pkg)` vars Separate platform-specific files will allow avoiding a lot of CPP.
Ericson2314
force-pushed
the
mingw-devops
branch
from
1d78fc3 to
77205b2
Compare
Member
Author
|
OK I removed the unix subdirs, just keeping the |
Member
Author
|
#10346 follow up issue from review. |
8 tasks
jlesquembre
added a commit
to tweag/nix
that referenced
this pull request
Mar 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
These changes are needed to enable a MinGW build. The most interesting part is support for platform-specific subdirectories to avoid excess CPP. They are not yet used, but will be once we start separating out the larger chunks of platform-specific code.
Context
First few commits of #8901
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.