Always print addErrorContext#10305
Merged
thufschmitt merged 4 commits intoNixOS:masterfrom Mar 29, 2024
Merged
Conversation
github-actions
bot
added
the
with-tests
9999years
reviewed
Mar 25, 2024
9999years
reviewed
Mar 25, 2024
roberth
force-pushed
the
addErrorContext-is-great
branch
from
09e4c1c to
05d84e6
Compare
Co-authored-by: Rebecca Turner <[email protected]>
roberth
force-pushed
the
addErrorContext-is-great
branch
from
05d84e6 to
d4fa0a8
Compare
9999years
approved these changes
Mar 27, 2024
Contributor
|
Looks good. These still need work. (I can imagine it being frustrating that source code positions are not shown for these messages.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
addErrorContexttraces are sufficiently valuable and usually terse, so they should always be shown.Context
addErrorContexttraces by default #7553--no-trace, which might actually be confusing, because of--no-show-trace, which is a simple negation of--show-trace.Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.