PosixSourceAccessor::cachedLstat(): Use absolute path#10151
Merged
thufschmitt merged 2 commits intoNixOS:masterfrom Mar 5, 2024
Merged
PosixSourceAccessor::cachedLstat(): Use absolute path#10151thufschmitt merged 2 commits intoNixOS:masterfrom
thufschmitt merged 2 commits intoNixOS:masterfrom
Conversation
Using the relative path can cause collisions between cache entries for PosixSourceAccessors with different roots.
Merged
thufschmitt
approved these changes
Mar 5, 2024
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.20-maintenance
git worktree add -d .worktree/backport-10151-to-2.20-maintenance origin/2.20-maintenance
cd .worktree/backport-10151-to-2.20-maintenance
git switch --create backport-10151-to-2.20-maintenance
git cherry-pick -x 9ee590e11301cda2b5d6341fb77f13369c3107e6 4967c5ff6ba96b27ad1d855b3b32712c0fc3dfcf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Using the relative path can cause collisions between cache entries for
PosixSourceAccessors with different roots.Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.