Skip to content

LockedFlake::getFingerprint(): Use Input::getFingerprint()#10149

Merged
edolstra merged 2 commits intoNixOS:masterfrom
edolstra:use-flake-fingerprint
Mar 7, 2024
Merged

LockedFlake::getFingerprint(): Use Input::getFingerprint()#10149
edolstra merged 2 commits intoNixOS:masterfrom
edolstra:use-flake-fingerprint

Conversation

@edolstra
Copy link
Member

@edolstra edolstra commented Mar 4, 2024

Motivation

Extracted from lazy-trees.

Context

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@github-actions github-actions bot added the fetching Networking with the outside (non-Nix) world, input locking label Mar 4, 2024
@edolstra edolstra merged commit 38b79da into NixOS:master Mar 7, 2024
@edolstra edolstra deleted the use-flake-fingerprint branch March 7, 2024 09:18
edolstra added a commit that referenced this pull request Mar 7, 2024
This wasn't caught by CI because #10149 and #10152 pass
individually... It doesn't happen on lazy-trees either because we
never try to fetch relative path flakes (#10089).
kognise added a commit to kognise/nix that referenced this pull request Jul 11, 2024
- Fix eval cache not being persisted in `nix develop` (since NixOS#10570)
- Fallback to flake path so the eval cache isn't disabled for flakes evaluated by a relative `path:` (since NixOS#10149, NixOS#10176)
- Don't attempt to commit cache transaction if there is no active transaction, which will spew errors in edge cases
- Drive-by: trivial typo fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fetching Networking with the outside (non-Nix) world, input locking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant