profile install: warn on installing package twice#10090
Merged
edolstra merged 2 commits intoNixOS:masterfrom Feb 29, 2024
Merged
profile install: warn on installing package twice#10090edolstra merged 2 commits intoNixOS:masterfrom
edolstra merged 2 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
new-cli
edolstra
reviewed
Feb 27, 2024
bobvanderlinden
force-pushed
the
profile-error-install-twice
branch
from
7b113c4 to
26403ac
Compare
thufschmitt
approved these changes
Feb 28, 2024
edolstra
changed the title
edolstra
approved these changes
Feb 28, 2024
bobvanderlinden
force-pushed
the
profile-error-install-twice
branch
from
26403ac to
6722aca
Compare
bobvanderlinden
force-pushed
the
profile-error-install-twice
branch
from
6722aca to
14adff1
Compare
|
Hi! Would there be a way to make For example, if I'm installing a tool from local repository with |
Member
Author
|
It may be a good idea to create an issue. I can take a look at it if there is a concrete plan how that workflow should work. I think a separate flag (like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently it is possible to install a package twice.
This change explicitly checks for duplicate entries when installing packages. It'll look like:
To decide a duplicate, the name,
attrPathandoriginalRef(flake:nixpkgs) should be the same.lockedRef(github:NixOS/nixpkgs/2a34566b67bef34c551f204063faeecc444ae9da) is ignored. This is to make sure installing the package twice at any time in the future will still be a conflict.Context
Fixes #5587
As suggested in #10065 (comment)
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.