Skip to content

Comments

[Backport 2.20-maintenance] fetchToStore(): Don't always respect settings.readOnlyMode#10045

Merged
edolstra merged 2 commits into2.20-maintenancefrom
backport-10043-to-2.20-maintenance
Feb 20, 2024
Merged

[Backport 2.20-maintenance] fetchToStore(): Don't always respect settings.readOnlyMode#10045
edolstra merged 2 commits into2.20-maintenancefrom
backport-10043-to-2.20-maintenance

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Feb 20, 2024

Automatic backport to 2.20-maintenance, triggered by a label in #10043.

@edolstra @github-actions
Don't say "copying X to the store" in read-only mode
7f02d17 
(cherry picked from commit 6162105)
@edolstra @github-actions
fetchToStore(): Don't always respect settings.readOnlyMode
28dd392 
It's now up to the caller whether readOnlyMode should be applied. In
some contexts (like InputScheme::fetch()), we always need to fetch.

(cherry picked from commit 7cb4d0c)
@github-actions github-actions bot mentioned this pull request Feb 20, 2024
Merged
@edolstra edolstra merged commit adb1d56 into 2.20-maintenance Feb 20, 2024
@edolstra edolstra deleted the backport-10043-to-2.20-maintenance branch March 29, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roberth roberth Awaiting requested review from roberth

@edolstra edolstra Awaiting requested review from edolstra edolstra is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Nix team
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@edolstra