fetchToStore(): Don't always respect settings.readOnlyMode#10043
Merged
thufschmitt merged 2 commits intoNixOS:masterfrom Feb 20, 2024
Merged
fetchToStore(): Don't always respect settings.readOnlyMode#10043thufschmitt merged 2 commits intoNixOS:masterfrom
thufschmitt merged 2 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
with-tests
edolstra
force-pushed
the
fix-readonly-fetchToStore
branch
from
ce374df to
a004b7c
Compare
edolstra
force-pushed
the
fix-readonly-fetchToStore
branch
from
a004b7c to
349f5d9
Compare
thufschmitt
reviewed
Feb 20, 2024
Member
thufschmitt
left a comment
thufschmitt
left a comment
There was a problem hiding this comment.
Makes sense, indeed
Fixes #10039.
That seems strange. Is it the right issues?
In that case, can you add a test case for it?
Member
Author
|
Sorry, I meant #10040. |
It's now up to the caller whether readOnlyMode should be applied. In some contexts (like InputScheme::fetch()), we always need to fetch.
edolstra
force-pushed
the
fix-readonly-fetchToStore
branch
from
349f5d9 to
7cb4d0c
Compare
thufschmitt
approved these changes
Feb 20, 2024
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
It's now up to the caller whether
readOnlyModeshould be applied. In some contexts (likeInputScheme::fetch()), we always need to fetch.This fixes commands like
nix search nixpkgs firefoxwhen thenixpkgsflake is not already in the store.Fixes #10040.
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.