-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Description
Describe the bug
builtins.fetchGit has a mode where if you pass a local directory and no ref nor rev, it uses the state of the tracked files in the Git working directory.
With pure evaluation, this mode is almost unusable, because it requires a narHash, even though paths in pure evaluation mode will always be in the Nix store, and therefore implicitly pure.
Steps To Reproduce
This can be reproduced with both stable Nix and Flakes, it doesn't depend on any experimental features, but I'll use Flakes since it's really hard to use pure evaluation mode without it.
-
Create this
flake.nixfile in a new empty Git repository:{ outputs = { ... }: # Show that ./. is in the Nix store in pure eval builtins.trace ./. { withoutHash = builtins.fetchGit ./.; withHash = builtins.fetchGit { url = ./.; # Setting this hash changes it! narHash = ""; }; }; }
-
Try to evaluate
fetchGitwithout providing anarHash, notice how it doesn't let us. Note that we usepath:so that the.gitdirectory is also available:$ nix eval path:.#withoutHash trace: /nix/store/0hnwhrv57lcxjsk6d81p12ggi8y6pd2d-source error: in pure evaluation mode, 'fetchTree' requires a locked input, at «none»:0 -
Try to evaluate
fetchGitwith an emptynarHash:$ nix eval path:.#withHash trace: /nix/store/0hnwhrv57lcxjsk6d81p12ggi8y6pd2d-source warning: Git tree '/nix/store/0hnwhrv57lcxjsk6d81p12ggi8y6pd2d-source' is dirty error: NAR hash mismatch in input 'git+file:///nix/store/0hnwhrv57lcxjsk6d81p12ggi8y6pd2d-source' (/nix/store/w8y68nl6642mmyhh2204hfhsa5yy5195-source), expected 'sha256-AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=', got 'sha256-YZHo9RvTnZi8xJJrns12YSFJcg2yfRrYbV4mS25nyqw='This gives us the correct hash, however this would prevent us from including
flake.nixin Git, since that would then influence the hash again, and we can't put the hash into a file influenced by the hash.
Expected behavior
builtins.fetchGit ./. in pure evaluation mode should just work, since the path will refer to a store path, which is always pure.
nix-env --version output
nix-env (Nix) 2.15.1
Additional context
This issue is sponsored by Antithesis ✨
Priorities
Add 👍 to issues you find important.