Skip to content

Creating missing state directories if they don't already exist is racey #2706

New issue
New issue
Closed
#13368
Closed
Creating missing state directories if they don't already exist is racey#2706
#13368
Labels
buggood first issueQuick win for first-time contributors
@grahamc

Description

@grahamc
grahamc
opened on Feb 28, 2019

nix/src/libstore/local-store.cc

Lines 68 to 71 in ebd4d50

if (!pathExists(gcRootsDir)) {
createDirs(gcRootsDir);
createSymlink(profilesDir, gcRootsDir + "/profiles");
}

When running a Nix build inside a Nix build with parallel nix-build's, I often see race conditions here:

error: creating symlink from '/tmp/nix-build-foo.drv-0/nix-test/nix/var/nix/gcroots/profiles' to '/tmp/nix-build-foo.drv-0/nix-test/nix/var/nix/profiles': File exists

Metadata

Metadata

Assignees

No one assigned

    Labels

    buggood first issueQuick win for first-time contributors

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions