-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Open
Labels
bugfetchingNetworking with the outside (non-Nix) world, input lockingNetworking with the outside (non-Nix) world, input lockingidea approvedThe given proposal has been discussed and approved by the Nix team. An implementation is welcome.The given proposal has been discussed and approved by the Nix team. An implementation is welcome.
Milestone
Description
Describe the bug
Currently we use un-smudge-ed aka clean blobs when getting files from a remote Git repo.
However, when the workdir has dirty files, we do not clean the files as part of the fetching.
Steps To Reproduce
- Have a local repo with smudging
- Edit a smudged file, do not commit
nix buildwith it- Commit and push to remote (remote shouldn't be necessary for the repro, but this is likely where users encounter it)
nix buildthe remote with the commit- Observe that 4 or the combination of 4 and 5 have
clean-ed the file, and the evaluation of 3 and 5 are different.
Expected behavior
Git-managed repos always produce the same results, as if the changes were committed.
Metadata
Additional context
I've found this problem by reading the source some time ago, but this has not been fixed yet.
Add 👍 to issues you find important.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugfetchingNetworking with the outside (non-Nix) world, input lockingNetworking with the outside (non-Nix) world, input lockingidea approvedThe given proposal has been discussed and approved by the Nix team. An implementation is welcome.The given proposal has been discussed and approved by the Nix team. An implementation is welcome.