Merged
Conversation
sternenseemann
force-pushed
the
Cabal-3.14
branch
from
17a0ce2 to
8563252
Compare
Member
Author
|
I've revised 1.4 to forbid Cabal >= 3.14. |
This will ease adding CPP directives for Cabal 3.14 compatibility.
readGenericPackageDescription now uses interpretSymbolicPath internally [1] which allows for passing in a CWD directory explicitly rather than just inheriting it from the running process. We want to preserve the old behavior and behave the same as writeGenericPackageDescription which does not use interpretSymbolicPath, so we pass Nothing. This amounts to the same behavior as just returning the underlying path (which is what we had before) [2] [3]. This also seems safer since readGenericPackageDescription seems to assume that the passed in CWD directory matches the process working directory [1]. [1]: https://github.com/haskell/cabal/blob/Cabal-v3.14.1.0/Cabal/src/Distribution/Simple/PackageDescription.hs#L83-L84 [2]: https://github.com/haskell/cabal/blob/Cabal-v3.14.1.0/Cabal-syntax/src/Distribution/Utils/Path.hs#L288-L305 [3]: https://github.com/haskell/cabal/blob/Cabal-v3.14.1.0/Cabal-syntax/src/Distribution/Utils/Path.hs#L257-L259
sternenseemann
force-pushed
the
Cabal-3.14
branch
from
8563252 to
738a9d6
Compare
This was referenced Dec 24, 2024
maralorn
approved these changes
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.