Skip to content

add systems#42

Merged
zimbatm merged 1 commit intomasterfrom
systems
Apr 25, 2023
Merged

add systems#42
zimbatm merged 1 commit intomasterfrom
systems

Conversation

@zimbatm
Copy link
Member

@zimbatm zimbatm commented Apr 9, 2023

This allows flake users to make the systems list externally extensible.
The default systems is:

[
  "aarch64-darwin"
  "aarch64-linux"
  "x86_64-darwin"
  "x86_64-linux"
]

See https://github.com/nix-systems/nix-systems for a full explanation

This allows flake users to make the systems list externally extensible.
The default systems is:
```
[
  "aarch64-darwin"
  "aarch64-linux"
  "x86_64-darwin"
  "x86_64-linux"
]
```

See https://github.com/nix-systems/nix-systems for a full explanation
@zimbatm
Copy link
Member Author

zimbatm commented Apr 9, 2023

Looking at the inclusion policy, this PR satisfies the utility criteria (3). But "systems" is quite generic so (2) is negative. In my opinion (3) outweighs (2)

@bb010g
Copy link
Contributor

bb010g commented Apr 13, 2023

systems is a common name, but I don't think it's at risk of being mistyped. 👍 on criteria 2 from me, and flake-utils's usage has probably helped critera 4 a lot.

@arcuru
Copy link

arcuru commented Apr 13, 2023

I like this pattern, and even though I'm generally against the global registry entirely I think that it probably makes sense to reserve this name for this use case. I'd prefer if it was builtin somehow, but systems existing as just a list of default systems shouldn't be surprising to anyone.

However, I do suggest leaving this open for a while to make sure the pattern is actually adopted by the ecosystem. Repos that one of the creators is able to self-merge into shouldn't really count as it being popular under criteria 4.

I think that branches for individual systems probably works better for usability than different repos though, and it would allow this to just take the place of 1 spot in the registry.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nix-systems-externally-extensible-flake-systems/27110/10

@zimbatm
Copy link
Member Author

zimbatm commented Apr 13, 2023

I'll wait another week and then merge it.

@zimbatm
Copy link
Member Author

zimbatm commented Apr 25, 2023

alright, time's up! :)

@zimbatm zimbatm merged commit 8054bfa into master Apr 25, 2023
@zimbatm zimbatm deleted the systems branch April 25, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants