⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.79%. Comparing base (ad7def0) to head (76adfe1).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main     #716   +/-   ##
=======================================
  Coverage   68.79%   68.79%           
=======================================
  Files          46       46           
  Lines       30992    30992           
=======================================
  Hits        21318    21318           
  Misses       9674     9674           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

REV Review — PR #716: fix(tests): stable conninfo query and SCRAM port for wrong-password test

Summary

Fixes two pre-existing test failures: replaces the version-sensitive \conninfo psql metacommand with a stable SQL query that produces identical output across all psql/rpg versions, and routes the wrong-password test to a dedicated SCRAM-auth Postgres container so the test actually validates authentication rejection (trust-auth silently accepts any password).

Blocking findings

None.

Non-blocking findings

• tests/compat/test-connections.sh line ~30: CONN_QUERY uses uppercase SELECT keyword. Per the SQL style guide, keywords must be lowercase (select current_database() AS db, ...). — INFO, guidelines-checker.

• tests/compat/test-connections.sh line ~30: The comment # Stable SQL used in place of \conninfo for A1-A5 is slightly inaccurate — CONN_QUERY is also used in A9 (unix socket). Should say "A1–A5, A9" or "all non-SCRAM tests". — LOW, docs-reviewer.

Potential issues

• SCRAM enforcement not explicit (confidence: 4/10): The postgres-scram CI container sets POSTGRES_PASSWORD but not POSTGRES_HOST_AUTH_METHOD=scram-sha-256. The postgres:16 Docker image defaults to scram-sha-256 when a password is set, so this works today. If the base image ever changes that default, the wrong-password test could silently degrade to md5 auth and still pass. Adding POSTGRES_HOST_AUTH_METHOD: scram-sha-256 to the service env would make the intent explicit and resilient to image changes.

• inet_server_port() returns NULL on Unix sockets (confidence: 7/10, low impact): test_unix_socket (A9) now uses CONN_QUERY, which includes inet_server_port(). This returns NULL for Unix socket connections. Both psql and rpg return the same NULL, so the comparison still passes — but the output will show a NULL port column, which is slightly misleading if anyone reads test output. Not a correctness issue.

Test coverage

Good. The two changes together make the test suite genuinely meaningful:

1. CONN_QUERY (select current_database() AS db, current_user AS usr, inet_server_port() AS port) produces deterministic tabular output that is identical between psql and rpg regardless of version. The previous \conninfo was a psql-internal metacommand whose output format changed in psql 18 — the replacement is strictly better.

2. The wrong-password test (A7) was previously a no-op against a trust-auth instance. Now it runs against a real SCRAM container in CI and gracefully skips in local dev when TEST_PG_SCRAM_PORT is unset. The test is self-validating: if the container accidentally used trust auth, rpg would exit 0 and the expect_failure helper would catch it as FAIL.

CI integration is correct: health checks ensure the container is ready before tests run, the job fails the pipeline on any test failure, and no allow_failure escape hatches are present.

Verdict

APPROVE