Repository navigation
fix(rider): disable extend-contract button before click when rider is at the cap - #3169
Conversation
… at the cap Riders at the #3143 contract-extension cap (current season + 3) still showed a normal, clickable "Extend contract" button — the 178 riders across 14 teams standing exactly on the cap all hit a 409 only AFTER clicking, since backend was the only place that knew the rule. RiderManageActions and TeamPage's RiderActionModal now prefetch the existing extend-quote response silently on mount and disable the button + show an explanatory line when it reports contract_extension_cap_reached, instead of frontend re-deriving "current season + 3" itself. The cap rule stays backend-only. Refs #3164 Co-Authored-By: Claude Fable 5 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reached
Next review available in: 51 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🟡 Lighthouse (advisory — blokerer ikke)Lab-måling af den byggede frontend (
Fuld rapport-URL i job-artifact |
|
✅ Deploy verificeret LIVE —
Du kan trygt lukke telefonen — det er live. |
…ose race window (#3186) (#3218) Sentry CYCLINGZONE-45 kept logging rejected rider_extend_quote attempts even after #3169's "disable when capped" fix, because the trigger button/tab was only disabled AFTER the async cap-check resolved - a player who clicked during that in-flight window (slow mobile network, or just a fast tap) still reached a doomed request. 5 of 10 Sentry events post-dated #3169. - backend/lib/contractSeed.js: new pure helper contractExtensionCapInfo() derives "X/3 extensions used" from the rider's current contract_end_season and currentSeason, without frontend re-deriving the "+3" cap formula. - backend/routes/api.js: GET/POST extend-quote and extend-contract now send extensionCap in every branch (allowed and 409), so the counter is visible before the player acts, not only after a rejection. - frontend RiderManageActions.jsx + TeamPage.jsx: trigger button/tab is now disabled for the ENTIRE async cap-check (not just once capped=true), closing the race window, and render an always-visible "Extensions used: X/3" / "Forlængelser brugt: X/3" line (EN+DA) alongside the existing disabled+explanation state. Refs #3186 Co-authored-by: Nicolai Dolmer <[email protected]> Co-authored-by: Claude Fable 5 <[email protected]>
…ation (#3172) (#3222) * fix(ci): isolate economyEngine.test.js to stop worker-IPC flake backend/lib/economyEngine.test.js is by far the largest backend test file (100+ tests, 6500+ lines, ~250KB) and its per-worker result payload appears large enough to trip a known Node test-runner bug (nodejs/node#64061, root-caused and fixed upstream in nodejs/node#64706, merged 2026-07-26 but not yet in our pinned Node 24.x line) when many other test-file workers stream results back to the parent process concurrently. Isolated runs were always 102/102 (now 103/103) green; the flake only ever showed up in the full suite (#3169-CI, #3171-CI). Add backend/scripts/run-tests.js: runs economyEngine.test.js alone first, then every other backend test file exactly as before (same flags, same default concurrency) via explicit relative file paths so the two passes never overlap. Wire both npm test (backend/package.json - the one permitted package.json edit) and scripts/verify-local.ps1 (which called `node --test` directly, bypassing npm entirely) through this script so CI and local pre-push runs get the same protection. No dependency or lockfile changes. Verified with 5 consecutive `npm test` runs locally (103/103 + 4773/4773 every time, exit 0). Refs #3172 Co-Authored-By: Claude <[email protected]> * docs(learnings): postmortem for economyEngine.test.js worker-IPC flake Refs #3172 Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Nicolai Dolmer <[email protected]> Co-authored-by: Claude <[email protected]>
…rejection (#3597) (#3694) Sentry CYCLINGZONE-45 kept logging rejected rider_extend_quote calls after #3186 - 8 events / 7 users on 3-9 Aug, this time across Chrome desktop, Edge and Firefox desktop, not only iOS. Round three of the same symptom. Root cause: the frontend derived its whole blocked-state from one signal - "have we been REJECTED?" (extendCapped, set only by a 409 contract_extension_cap_reached). #3164/#3169 moved that check earlier, #3186 closed its in-flight race window, but both rounds kept the rejection-derived flag as the only gate. Any state transition that leaves extendCapped === false while capacity is actually 0 reopens the hole - and an ordinary successful extension does exactly that: confirmExtend()'s success branch drops the used quote (setExtendQuote(null)) and never touches extendCapped, while the mount check is keyed on [rider.id], which does not change. If that extension consumed the last allowed season, the button went gold and clickable again on a rider whose next extend-quote is guaranteed to 409. One click, one Sentry event - deterministic, hence the browser spread. #3186 had already added extensionCap to the success branch, so the client knew there were 0 left and displayed "Extensions used 3/3" - the number was just never wired to the button. - frontend/src/lib/extendCapGate.js: shared pure gate that blocks on the POSITIVE capacity number the backend already sends in every branch (extensionCap.remainingExtensions), with extendCapped as a fallback for responses that carry no extensionCap. A missing/null field means "unknown", not "0 left", so a response without the counter cannot deadlock the button. - RiderManageActions.jsx + TeamPage.jsx gate on that same function, so the two surfaces cannot diverge again. - RiderManageActions.jsx also resets extend state on rider change: the component is not remounted when navigating /riders/A -> /riders/B, so rider B used to inherit A's quote (panel showing A's salary terms) and A's extendCapped (B's button locked forever). - openExtend()'s error branch now locks on a 409 too, as confirmExtend() already did. Regression cover: rider-extend-cap-after-success.spec.js walks the player's path (extend a rider with one extension left, require the button locked afterwards, counter at 3/3, explanation visible, and no extend-quote reaching the backend). Verified as a negative control - it fails against the old disabled={extendCapped || extendLoading}. extendCapGate.test.js proves the gate itself plus the contract that both surfaces use it. No backend changes and no migrations - the extensionCap contract shipped with #3186 and is now used as intended. Postmortem: .claude/learnings/2026-08-14-extend-cap-gate-derived-from-rejection-not-capacity.md Refs #3597 Co-authored-by: Nicolai Dolmer <[email protected]> Co-authored-by: Claude Opus 5 <[email protected]>
Hvad
Rytter-kortets "Forlæng kontrakt"-knap er nu deaktiveret med forklarende tekst når rytteren allerede står på #3143-kontraktloftet (current season + 3), i stedet for at spilleren først opdager det efter et klik der altid ville fejle med
409 contract_extension_cap_reached.Refs #3164
Hvorfor
178 ryttere på 14 rigtige hold står præcis på loftet i dag (#3143, merged 30/7). Alle 14 managere rammer samme mur hver gang de prøver at forlænge — Sentry CYCLINGZONE-45 havde 5 hændelser / 4 spillere på 17 timer, og det fortsætter indtil UI'et matcher backend-reglen.
Triage-anbefalingen (fra issuet): backend-drevet flag i stedet for at frontend gentager
currentSeason + 3-regnestykket klientsidet (samme drift-klasse som #3071/#3081/#3150). Konkret implementering:RiderManageActions(rytterprofilen) ogTeamPage'sRiderActionModal(holdsidens administrationspanel) henter nu den EKSISTERENDEGET /riders/:id/extend-quote-route stille ved mount i stedet for ved klik. Rapporterer dencontract_extension_cap_reached, deaktiveres knappen (rytterprofil) hhv. "Forlæng"-fanen (holdside) og en forklarende linje vises — loft-tallet (errorParams.maxSeason) kommer 100% fra backend, ingen ny regnestykke-duplikering i frontend. Ingen ny route, ingen DB-ændring.Test plan
npm run build --prefix frontendpasserernpm test --prefix backendpasserer (4713/4714; det ene fejl varlib/economyEngine.test.jssom en isoleret worker-thread-deserialiseringsflake i test-runneren — kører 102/102 grønt i isolation, urelateret til denne PR)npm run lint --prefix frontendpasserer (kun 4 præeksisterendeloadAll-warnings, ingen af dem i rørte filer)pwsh -File scripts/verify-local.ps1(backend+frontend tests + frontend build) grønnpx playwright test core-smoke.spec.js— 27/27 grøn på tværs af alle 3 projekter (desktop-chromium, mobile-chromium, mobile-webkit)i18n-check-keys.mjs/i18n-check-icu-braces.mjs/i18n-check-duplicate-keys.mjsgrønne (nyemanage.extend.capped/actionModal.extend.capped-nøgler i alle 4 locale-filer)node scripts/check-patch-notes-version.jsgrøn (ny top-version 7.77)extend-quote/extend-contract-kontrakt-tests (backend/lib/riderActionsRoutes.test.js,backend/lib/contractSeed.test.js) uændrede og stadig grønne — [bug] Intet loft på gentagne kontraktforlængelser — lav løn kan låses til sæson 11+ (academy og senior) #3143-loftet er IKKE rørt, kun hvornår/hvordan frontend læser dets svarBrugerverifikation (KRÆVET)
Hvad jeg verificerede konkret: Jeg er en udførende agent uden interaktiv adgang til prod/preview i denne opgave, så jeg har IKKE klikket funktionen igennem i en levende browser som authenticated user. Verifikationen er: (1) Playwright
core-smoke.spec.jskører autentificerede flows gennem rytterprofil + holdside uden regressions på tværs af 3 projekter, (2) de eksisterende backend-kontrakt-tests forextend-quote/extend-contract(409 +errorParams.maxSeason) er uændrede og grønne, (3) frontend-build + lint er rene. Ejeren bør selv åbne en rytter på loftet (fx en af de 178 ryttere nævnt i #3164) på både rytterprofilen og holdsidens "Administrér"-modal i preview/prod og bekræfte at "Forlæng kontrakt" viser sig deaktiveret med forklarende tekst i stedet for at kunne klikkes.Risk / auto-merge
auto-mergeer kun sat hvis PR'en er lav-risiko og ikke kræver menneskelig beslutningpackage*.json, workflows, auth, DB eller upload-flow ændresIngen DB/schema/route-ændringer. Ren frontend-UX-ændring der genbruger en eksisterende, allerede testet backend-route. Lav risiko, men lades ikke auto-merge da UI-ændringer bør ejer-godkendes visuelt (se Brugerverifikation).
Filer rørt
frontend/src/components/rider/RiderManageActions.jsx— rod-årsagsfilen fra issuet: stille cap-prefetch ved mount, deaktiveret knap + forklaringfrontend/src/pages/TeamPage.jsx— samme mønster iRiderActionModal(holdsidens "Administrér"-modal, "Forlæng"-fanen)frontend/public/locales/{en,da}/rider.json— nymanage.extend.capped-nøglefrontend/public/locales/{en,da}/team.json— nyactionModal.extend.capped-nøglefrontend/src/data/patchNotes.js— ny patch notes-entry (version 7.77, refs Forlæng-kontrakt: spilleren får fejl EFTER klik i stedet for at se loftet på forhånd (178 ryttere på 14 hold rammer muren) #3164)Skærmbillede / video
Ikke vedhæftet — ingen interaktiv browser-adgang til preview i denne opgave. Se Brugerverifikation-sektionen ovenfor for hvad ejeren bør tjekke visuelt.
Close-out (efter merge til main)
frontend/src/data/patchNotes.js) opdateret med ny version (7.77)docs/NOW.md— ikke opdateret af denne worker-session (arbejder isoleret i worktree per opgavebeskrivelse); ejer/orkestrator opdaterer ved mergedocs/FEATURE_STATUS.md— ingen kontrakt-/runtime-state-ændring, ingen opdatering nødvendig.claude/learnings/<dato>-<slug>.md— overvej ved merge: rod-årsagen er samme mønster som [bug] Rytter-alder fryser i sæson 1 i hele frontenden — backend ælder, UI gør ikke #3071/[bug] Peak-assistenten regner alder på wall-clock — 121 ryttere får 1 peak i stedet for 2 i S2 #3081/[bug] Vækst-cap ser ud til ikke at ramme oprykkede ex-akademi-ryttere — +2/session rapporteret #3150 (frontend duplikerer ALDRIG en backend-spilleregel; hent i stedet backend-svaret tidligere/stille)claude:done— ejer/orkestrator gør dette efter verificeret merge (denne session merger/lukker ikke selv, per opgavebeskrivelse)