Repository navigation
Commit 51067f3
PR #3222's fix (run the file alone in its own pass) theorized the
"Unable to deserialize cloned data" test-runner bug needed concurrent
IPC traffic from other workers to trigger. That theory was disproven
the same evening: the isolated pass itself failed with the identical
error twice more (CI runs 30836291715 attempt 1 and 30840936886), both
with zero other workers running. One of the two was masked in
`gh run list` by a subsequent green rerun and only surfaced by
checking run_attempt > 1 directly via the GitHub REST API.
The bug (nodejs/node#64061, fixed upstream but not yet in our pinned
Node 24.x line) is triggered by this file's IPC payload size/shape
alone, not by concurrency. Running it "alone" only changed the odds of
hitting the exact buffer boundary; it never removed the vulnerable
code path (the file still ran as a child worker streaming results back
via socket + structured-clone).
Fix: run this one file with --test-isolation=none, which executes it
in the same process as the node --test invocation instead of spawning
a child worker. No child worker means no IPC round-trip for this file,
so processRawBuffer/FileTest.parseMessage (present in every crash
stack trace) are never invoked for it - the bug class cannot trigger
regardless of payload size or concurrent CI load. Scope is limited to
this one file/pass; the other ~340 backend test files keep default
process-per-file isolation unchanged.
Verified locally: 25/25 green runs with --test-isolation=none, 25/25
green with default isolation (no local repro - expected, the bug is
rare and CI-Linux-weighted), failure-propagation confirmed correct
(a deliberately failing test still exits 1), and the per-file
FileTest wrapper line from the crash traces is structurally absent
from --test-isolation=none output. 4x full npm test (4988/4988) green
after the change.
No dependency, lockfile, or package.json changes.
Refs #3172
Co-authored-by: Nicolai Dolmer <[email protected]>
Co-authored-by: Claude <[email protected]>
1 parent 6ae1d6a commit 51067f3
2 files changed
Lines changed: 111 additions & 23 deletions
File tree
- .claude/learnings
- backend/scripts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
9 | 8 | | |
10 | 9 | | |
11 | 10 | | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
| 11 | + | |
16 | 12 | | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
22 | 22 | | |
23 | | - | |
24 | | - | |
25 | | - | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
26 | 42 | | |
27 | 43 | | |
28 | 44 | | |
| |||
44 | 60 | | |
45 | 61 | | |
46 | 62 | | |
47 | | - | |
| 63 | + | |
48 | 64 | | |
49 | 65 | | |
50 | | - | |
| 66 | + | |
51 | 67 | | |
52 | 68 | | |
53 | 69 | | |
| |||
77 | 93 | | |
78 | 94 | | |
79 | 95 | | |
80 | | - | |
81 | | - | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
82 | 101 | | |
83 | 102 | | |
84 | 103 | | |
| |||
0 commit comments