Skip to content

Features and Fixes Part 2#377

Merged
nlogozzo merged 9 commits intomainfrom
more
Oct 22, 2023
Merged

Features and Fixes Part 2#377
nlogozzo merged 9 commits intomainfrom
more

Conversation

@nlogozzo
Copy link
Copy Markdown
Member

@nlogozzo nlogozzo commented Oct 22, 2023

@nlogozzo nlogozzo marked this pull request as ready for review October 22, 2023 03:45
@nlogozzo
Copy link
Copy Markdown
Member Author

nlogozzo commented Oct 22, 2023

@kissthermite
You can download and install the .flatpak file from the assets section on this CI build: https://github.com/NickvisionApps/Tagger/actions/runs/6601503583 to test the remembering of format strings and the sorting files by album with disc number while we wait for our backend's (atldotnet) developer to fix the flac file issue.

Just a note, the format string used for file name to tag will be remembered independently of that used by tag to file name.

Once you download and extract the .flatpak file from the assets, you can use these commands to install it:

#from the directory containing the .flatpak file
flatpak install org.nickvision.tagger-x64.flatpak
flatpak run org.nickvision.tagger//master

Once you've tested and are done with it (or you can keep using it until the next beta release) you can uninstall it with:

flatpak uninstall org.nickvision.tagger//master

Feel free to comment with any issues, comments, questions, or concerns :))

@kissthermite
Copy link
Copy Markdown

Feel free to comment with any issues, comments, questions, or concerns :))

name

It does remember my custom format string even after closing Tagger. Such a nice QOL. Good job @nlogozzo!

@kissthermite
Copy link
Copy Markdown

Feel free to comment with any issues, comments, questions, or concerns :))

name

name

And album sorting now behave the way i expected too. Another job well done!

@nlogozzo nlogozzo requested a review from fsobolev October 22, 2023 13:01
@nlogozzo
Copy link
Copy Markdown
Member Author

@kissthermite Glad everything works as expected :)

This build should contain the fix for PublishingDate and flac files: https://github.com/NickvisionApps/Tagger/actions/runs/6603980868

Once you confirm that works I will merge this PR and release RC1 and we should be all good for a stable release on Friday!

@kissthermite
Copy link
Copy Markdown

kissthermite commented Oct 22, 2023

@kissthermite Glad everything works as expected :)

This build should contain the fix for PublishingDate and flac files: https://github.com/NickvisionApps/Tagger/actions/runs/6603980868

Once you confirm that works I will merge this PR and release RC1 and we should be all good for a stable release on Friday!

name

it worked! 🚀

I just realized that there's currently no way to remove Publishing Date tag?

@nlogozzo
Copy link
Copy Markdown
Member Author

Yay!! I have to go to work now but once I get home later td I'll merge and do a release :)

@kissthermite
Copy link
Copy Markdown

Yay!! I have to go to work now but once I get home later td I'll merge and do a release :)

I just edited my comment in case you didn't see it.

I just realized that there's currently no way to remove Publishing Date tag?

name

That trash can button can be seen on Custom Properties
VORBIS-VENDOR would do nicely beside Pick a date/Date button

@nlogozzo
Copy link
Copy Markdown
Member Author

That trash can button can be seen on Custom Properties
VORBIS-VENDOR would do nicely beside Pick a date/Date button

Ah, good idea! Will implement that when I get home instead

@nlogozzo nlogozzo requested review from fsobolev and removed request for fsobolev October 22, 2023 17:28
@nlogozzo
Copy link
Copy Markdown
Member Author

That trash can button can be seen on Custom Properties
VORBIS-VENDOR would do nicely beside Pick a date/Date button

Ah, good idea! Will implement that when I get home instead

@kissthermite Ok, done! Use this build to test: https://github.com/NickvisionApps/Tagger/actions/runs/6605232433

Copy link
Copy Markdown
Member

@fsobolev fsobolev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should take disc number to consideration everywhere where we compare track numbers: for sorting by artist, year and genre too.

@nlogozzo
Copy link
Copy Markdown
Member Author

I think we should take disc number to consideration everywhere where we compare track numbers: for sorting by artist, year and genre too.

Done in latest commit!

@nlogozzo nlogozzo requested a review from fsobolev October 22, 2023 19:48
@kissthermite
Copy link
Copy Markdown

name

name


@nlogozzo another job completed fantastically!

@nlogozzo nlogozzo merged commit a3bfd37 into main Oct 22, 2023
@nlogozzo nlogozzo deleted the more branch October 22, 2023 20:18
@nlogozzo
Copy link
Copy Markdown
Member Author

@kissthermite RC1 will come in a little bit.

Just be advised that configurations are kept independent of branches. Meaning flatpak beta and flatpak master will be different. So upon installing rc1, your format string won't be remembered until you use it for the first time on the version.

@fsobolev
Copy link
Copy Markdown
Member

Just be advised that configurations are kept independent of branches. Meaning flatpak beta and flatpak master will be different. So upon installing rc1, your format string won't be remembered until you use it for the first time on the version.

Why is that? Flatpak data dir is always ~/.var/app/org.nickvision.tagger no matter the branch

@nlogozzo
Copy link
Copy Markdown
Member Author

Just be advised that configurations are kept independent of branches. Meaning flatpak beta and flatpak master will be different. So upon installing rc1, your format string won't be remembered until you use it for the first time on the version.

Why is that? Flatpak data dir is always ~/.var/app/org.nickvision.tagger no matter the branch

I could be wrong. I thought the whole branch was kept separate from each other. Guess it's just the binaries and the rest is shared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remember Format String Disc Tag Property Date Tag Property

3 participants