Skip to content

Features and a Fix :)#371

Merged
nlogozzo merged 33 commits intomainfrom
more
Oct 21, 2023
Merged

Features and a Fix :)#371
nlogozzo merged 33 commits intomainfrom
more

Conversation

@nlogozzo
Copy link
Copy Markdown
Member

@nlogozzo nlogozzo commented Oct 19, 2023

Fixes #365
Fixes #366

  • NOTE: With the implementation of this feature, I've introduced a new AlbumArt model.
    • This abstracts the previously used byte[] for FrontAlbumArt and BackAlbumArt into a full object which contains and exposes the underlying byte[] for the image, but also contains properties for an image's Width, Height, MimeType and AlbumArtType.
    • The Width and Height are processed and provided by the ImageSharp library.
    • MimeType is provided by ATL.PictureInfo.
    • An ATL.PictureInfo representation of the AlbumArt object is also accessible via the object's ATLPictureInfo property which manages and exposes this ATL object to prevent having to create it more times than needed when actually setting ATL.Track's picture.

Fixes #370
Fixes #372

Screenshots for new feature designs can be seen on individual issues themselves

@nlogozzo
Copy link
Copy Markdown
Member Author

#372 will come in a later PR

@nlogozzo nlogozzo marked this pull request as ready for review October 19, 2023 19:18
@nlogozzo nlogozzo requested a review from fsobolev October 19, 2023 19:18
@nlogozzo nlogozzo requested review from fsobolev and removed request for fsobolev October 19, 2023 19:19
@nlogozzo
Copy link
Copy Markdown
Member Author

#372 will come in a later PR

Nevermind I was able to squeeze it in!

@nlogozzo nlogozzo removed the request for review from fsobolev October 20, 2023 01:34
@nlogozzo nlogozzo requested a review from fsobolev October 20, 2023 01:34
@nlogozzo nlogozzo changed the title Fixes and Features Features and a Fix :) Oct 20, 2023
@nlogozzo nlogozzo requested review from fsobolev and removed request for fsobolev October 21, 2023 02:04
@nlogozzo nlogozzo merged commit 8346e9b into main Oct 21, 2023
@nlogozzo nlogozzo deleted the more branch October 21, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants