Conversation
|
C#'s |
- CreatePlaylistDialog asks for path to save through file picker - Added support for creating and reading playlists with relative paths
This doesn't make sense to me, libnotify is a library to send desktop notifications 😕 One more thing I want to change is filter in the file dialog can be used to select format instead of a separate comborow, I will work on that later today. |
|
I don't know i feel like all the formats arent exposed to the user this way. What we can do is if the user specifies the format in the file dialog (by providing the extension) then we can automatically select it in the format row. |
I don't get how they are not exposed, a dropdown in the dialog doesn't differ much from a comborow, but this way users will set filename with extension and the format in one place, and this will prevent situation when file extension doesn't match the format. |
Will the filter in the FileDialog only filters out files of that type. If the user isn't overwriting a file and just specifies the name without the extension, it doesn't get added on automatically...it's our job to do that...so we need to know the format the user wants still. |
And then the validation should fail because the format is unknown. I think it's expected to always save playlist file with extension. |
It's expected to save a playlist file with an extension yes, but we can't always expect the user to provide said extension as that's the nature of FileDialog...for example they may think that choosing the filter through the dialog is enough for choosing the format. Similar how in Denaro a user can never sepcificy .nmoney at the end of an account file, and we add it on manually. That's why I suggested that we keep the format row, but if the user specifies an extension in the file dialog we can change the format row to the extension they chose, otherwise they can still choose the format from the row and we will add the extension manually if needed. |
Ah, I understand now, okay.
Okay, will do this then. |
I could take care of this should just be a couple of lines and I'll time during the atternoon I believe to do it :) |
Huh, it seems like it depends on file chooser. Here on KDE it always adds Also, FPL should be removed from the list. |
If you change the filter in the KDE dialog does it add the right extension?
Well what I have in mind for fixing this will handle both these cases on Gnome and KDE
👍, however, i'll open an issue on ATL because it's listed there as supported. |
|
I will check, it should, currently we have only "All formats" so it was using the first one inside it |
Ah I thought I added all individual ones as well. Will do that and the fixes I had planned and we can check after if that solves everything. Just be a little bit till I get home from work...busy day today 😅 |
If I choose individual filter then an extension is added correctly. |
|
@fsobolev Okay try latest commit, should all be good! |
Closes #322
Closes #332
Here's the new file system watcher:

Here's the new create playlist dialog:

Also added a library mode indicator icon to the bottom bar:

