Merged
Conversation
* fix deepedit/nuclick transforms for metatensor Signed-off-by: Sachidanand Alle <[email protected]>
[DLMED] add update API for config parser Signed-off-by: Nic Ma <[email protected]>
* Add TCIA dataset Signed-off-by: Yiheng Wang <[email protected]>
* dataset summary for metatensor Signed-off-by: Wenqi Li <[email protected]> * dataset summary support metatensor Signed-off-by: Wenqi Li <[email protected]> * fixes tests Signed-off-by: Wenqi Li <[email protected]>
* fix metatensor for detection Signed-off-by: Can Zhao <[email protected]> * fix mypy Signed-off-by: Can Zhao <[email protected]>
* update detection transforms for metatensor Signed-off-by: Wenqi Li <[email protected]> * fixes mypy Signed-off-by: Wenqi Li <[email protected]> * more tests about applied operations Signed-off-by: Wenqi Li <[email protected]>
* optional final Tanh Signed-off-by: Wenqi Li <[email protected]> * update param name Signed-off-by: Wenqi Li <[email protected]>
* add user warnings in AsChannelFirst and AddChannel Signed-off-by: KumoLiu <[email protected]> * change warning to deprecated Signed-off-by: KumoLiu <[email protected]> * change since0.9 to 0.8 Signed-off-by: KumoLiu <[email protected]> * add use MetaTensor data type Signed-off-by: KumoLiu <[email protected]> * fix pep8 Signed-off-by: KumoLiu <[email protected]>
* support block type string in resnet, senet Signed-off-by: KumoLiu <[email protected]> * fix docstring Signed-off-by: KumoLiu <[email protected]> * fix docstring in resnet Signed-off-by: KumoLiu <[email protected]> Co-authored-by: Yiheng Wang <[email protected]>
* [DLMED] add track_meta option Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
* Makes self.data mutable Signed-off-by: Behrooz <[email protected]>
* add allow_missing_keys in EnsureChannelFirstd Signed-off-by: KumoLiu <[email protected]> * fix flake8 error Signed-off-by: KumoLiu <[email protected]>
[DLMED] enhance spacing and orientation Signed-off-by: Nic Ma <[email protected]>
* add Metatenosr support in ConcatItemd Signed-off-by: KumoLiu <[email protected]>
* fixes #4747 padding Signed-off-by: Wenqi Li <[email protected]>
* permanent dataset hashes transforms Signed-off-by: Richard Brown <[email protected]> * fixes Signed-off-by: Richard Brown <[email protected]> * documentation Signed-off-by: Richard Brown <[email protected]> * default to no hash Signed-off-by: Wenqi Li <[email protected]> Co-authored-by: Wenqi Li <[email protected]>
* update changelog Signed-off-by: Wenqi Li <[email protected]> * remove warning msg Signed-off-by: Wenqi Li <[email protected]> * update n workers for smaller testing memory usage Signed-off-by: Wenqi Li <[email protected]>
* update patch merging Signed-off-by: Wenqi Li <[email protected]> * fixes unit tests Signed-off-by: Wenqi Li <[email protected]>
* fixes #4761 Signed-off-by: Wenqi Li <[email protected]> * update v0.9.1 Signed-off-by: Wenqi Li <[email protected]>
* mri utils added Signed-off-by: mersad95zd <[email protected]> * fft_utils with its unit test added Signed-off-by: mersad95zd <[email protected]> * fft_utils updated with monai data converter Signed-off-by: mersad95zd <[email protected]> * updated fft_util's docstring Signed-off-by: mersad95zd <[email protected]> * apps.rst updated with fft_utils docstrings under the reconstruction module Signed-off-by: mersad95zd <[email protected]> * fft_utils docstring updated by adding dimension hins Signed-off-by: mersad95zd <[email protected]> * fft_utils docstring updated by removing redundant output type Signed-off-by: mersad95zd <[email protected]> * test_fft_utils.py moved to the tests folder Signed-off-by: mersad95zd <[email protected]> * created fft_utils_t, the torch-only version of fft_utils Signed-off-by: mersad95zd <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fft_utils_t updated with type ignore for mypy Signed-off-by: mersad95zd <[email protected]> * docs/source/networks.rst updated with fft_utils_t Signed-off-by: mersad95zd <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * manual fix for fft_utils_t output data types Signed-off-by: mersad95zd <[email protected]> * initial mri_transforms added under apps/reconstruction Signed-off-by: mersad95zd <[email protected]> * with PR1 files to avoid error Signed-off-by: mersad95zd <[email protected]> * PR1 included Signed-off-by: mersad95zd <[email protected]> * PR1 files finally removed Signed-off-by: mersad95zd <[email protected]> * putting test_mri_transforms under apps for now Signed-off-by: mersad95zd <[email protected]> * isort fixed Signed-off-by: mersad95zd <[email protected]> * ignore this commit, still in progress Signed-off-by: mersad95zd <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * created utils, array, and dictionary; still a very early-stage commit Signed-off-by: mersad95zd <[email protected]> * completing transform arrays and dicts plus mri_utils and the unit tests Signed-off-by: mersad95zd <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * move tests under apps for now Signed-off-by: mersad95zd <[email protected]> * fixed docs and tests Signed-off-by: mersad95zd <[email protected]> * fast-mri-reader initial commit; todo is the unittest Signed-off-by: mersad95zd <[email protected]> * unittest added Signed-off-by: mersad95zd <[email protected]> * remove unncessary packages from the reader Signed-off-by: mersad95zd <[email protected]> * manual installation of h5py added Signed-off-by: mersad95zd <[email protected]> * enum keys added Signed-off-by: mersad95zd <[email protected]> * h5py added to requirements-dev.txt Signed-off-by: mersad95zd <[email protected]> * optional import of h5py Signed-off-by: mersad95zd <[email protected]> * fixed h5py dependency Signed-off-by: mersad95zd <[email protected]> * fixed h5py dependency again Signed-off-by: mersad95zd <[email protected]> * fixed docstring; fixed import issue Signed-off-by: mersad95zd <[email protected]> * added h5py to relevant requirement files; updated fastmri_reader Signed-off-by: mersad95zd <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * docs updated Signed-off-by: mersad95zd <[email protected]> * fixed os.path.basename Signed-off-by: mersad95zd <[email protected]> * support for multi-channel inputs Signed-off-by: mersad95zd <[email protected]> * docstring fixed Signed-off-by: mersad95zd <[email protected]> * minor argument fix Signed-off-by: mersad95zd <[email protected]> Co-authored-by: Can Zhao <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Wenqi Li <[email protected]>
* Implement GridSplit using torch.as_strided Signed-off-by: Behrooz <[email protected]>
added YanxuanLiu as blossom trigger user Signed-off-by: YanxuanLiu <[email protected]> Co-authored-by: YanxuanLiu <[email protected]>
fixes #4774 Signed-off-by: Wenqi Li <[email protected]>
* update test cases Signed-off-by: Wenqi Li <[email protected]> * fixes flake8 Signed-off-by: Wenqi Li <[email protected]> * fixes tests Signed-off-by: Wenqi Li <[email protected]>
fixes docstring Signed-off-by: Wenqi Li <[email protected]>
* adds meta[space] Signed-off-by: Wenqi Li <[email protected]> * fixes unit test Signed-off-by: Wenqi Li <[email protected]>
* Change from round to floor Signed-off-by: Behrooz <[email protected]> * Explicit conversion to tuple for locs Signed-off-by: Behrooz <[email protected]>
* Update patch merging with a for loop Signed-off-by: function2 <[email protected]> * Make patch merging order backward compatible for 2D Signed-off-by: function2 <[email protected]>
Signed-off-by: Wenqi Li <[email protected]> Fixes #5414 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]> Fixes #5413 ### Description excluding background shouldn't be done before softmax ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]> Fixes #5422 ### Description the kernel size and strides are hard-coded: https://github.com/Project-MONAI/MONAI/blob/a209b06438343830e561a0afd41b1025516a8977/monai/networks/nets/attentionunet.py#L151 this PR makes the values tunable. `level` parameter is not used and removed in this PR. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]>
Fixes #5425 tested: https://github.com/Project-MONAI/MONAI/actions/runs/3344552788 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Ben Murray <[email protected]> Fixes # . ### Description A few sentences describing the changes proposed in this pull request. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [x] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [x] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Ben Murray <[email protected]>
Signed-off-by: Wenqi Li <[email protected]> Fixes #5432 Fixes Project-MONAI/MONAILabel#1064 ### Description convert potential itk types in `img.GetMetaDataDictionary()` to numpy arrays ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]>
follow-up of #4922 ### Description - minimal interface to track the pending transforms via metatensor - transforms.Flip is modified as an example for discussion - discussion points: - maintaining `pending_operations` and `applied_operations` independently? - the data structure for `pending_operations` element is a python dictionary - transform "functional" refactoring ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [x] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]>
Fixes #5390 . ### Description This PR simplified the `hash key` caching mode in the `CacheDataset` to use `list` as cache type, same as regular cache. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Nic Ma <[email protected]> Signed-off-by: monai-bot <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: monai-bot <[email protected]>
This refactors CumulativeAverage() by removing subclassing from Cumulative() to have much less overhead, and adds additionan functionality to specify count. (as discussed here #5380) CumulativeAverage previously was not used almost anywhere, except for MIL tutorial. Name of class methods .aggregate() and .append() are preserved, so it should work the same way as before (non-breaking). New tests are added (especially to test in multi-gpu DDP) ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: myron <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Mingxin Zheng <[email protected]> Fixes #5427 . ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [x] New tests added to cover the changes. - [x] In-line docstrings updated. Signed-off-by: Mingxin Zheng <[email protected]>
Fixes #5188 ### Description This PR reimplement `SobelGradients` and `SobelGradientsd` using separable kernels and generalize it to images with any spatial dimension (2D, 3D, etc.) and option to calculate the gradient along any given axis. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [x] New tests added to cover the changes. - [x] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. Signed-off-by: Behrooz <[email protected]>
Signed-off-by: monai-bot <[email protected]> fixes #5444 Signed-off-by: monai-bot <[email protected]> Signed-off-by: Wenqi Li <[email protected]> Co-authored-by: Wenqi Li <[email protected]> Co-authored-by: Wenqi Li <[email protected]>
Fixes #3881 Follow-up of Project-MONAI/tutorials#481 ### Description following https://github.com/InsightSoftwareConsortium/ITK/blob/15aa8d58a01a1279e1fafa2214c82edd80b17e92/Modules/IO/NIFTI/src/itkNiftiImageIO.cxx#L2174-L2176 ### Status **Ready** ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]>
Fixes #5310 . ### Description Add a post transform to process NP branch output(an output branch in HoVerNet) which turns the probability map from the network into the instance segmentation result. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [x] New tests added to cover the changes. - [x] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [x] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: KumoLiu <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Behrooz Hashemian <[email protected]> Co-authored-by: Nic Ma <[email protected]>
Signed-off-by: monai-bot <[email protected]> - auto style fixing - bump versioneer to 0.23 from 0.19 Signed-off-by: monai-bot <[email protected]> Signed-off-by: Wenqi Li <[email protected]> Co-authored-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]> it's not easy to always keep the dco signing-off line when the pull requests have many commits and rebasing. And the current instructions of rebasing commits for DCO don't work properly in many cases ([example](https://github.com/Project-MONAI/MONAI/pull/5377/checks?check_run_id=9245758301)). This PR set the option https://github.com/dcoapp/app#individual-remediation-commit-support so that the signing-off could be done via follow-up commits retroactively. the new instructions for signing the PR will be provided similarly to this testing example: https://github.com/gr2m/sandbox/runs/4221328432 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Lee Newberg <[email protected]> ### Description Re-writes version numbers as strings rather than numbers because 3.1 != 3.10, etc. Nothing is broken at present but in the future as, e.g., the Python version for some things goes from 3.8 to 3.9 to 3.10, this could end up being an unexpected problem. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). Signed-off-by: Lee Newberg <[email protected]>
Signed-off-by: KumoLiu <[email protected]> Fixes #5028. ### Description Since the output for HoVerNet is a dictionary, we already have `PrepareBatchExtraInput` to support extra input data for the network, but it still can't meet the requirements. This PR is to extend `PrepareBatchExtraInput` to make the label can be a dictionary. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: KumoLiu <[email protected]> Co-authored-by: Nic Ma <[email protected]>
Signed-off-by: KumoLiu <[email protected]> Fixes #5466. ### Description In `GeneralizedDiceLoss`, now it do channel reduction before reduction, remove channel reduction in this PR. https://github.com/Project-MONAI/MONAI/blob/c38d503a587f1779914bd071a1b2d66a6d9080c2/monai/losses/dice.py#L360-L363 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: Wenqi Li <[email protected]> ### Description allow `config_file=None` when running `python -m monai.bundle run`, this enables convenient quick runs via CLI, for example: ```bash python -m monai.bundle run my_test --my_test="$print('hello')" ``` ```bash python -m monai.bundle run my_test --my_test="{_target_: LoadImage}" ``` output after this PR: ``` `config_file` not provided for 'monai.bundle run'. 2022-11-04 12:16:42,463 - INFO - --- input summary of monai.bundle.scripts.run --- 2022-11-04 12:16:42,463 - INFO - > runner_id: 'my_test' 2022-11-04 12:16:42,463 - INFO - > my_test: {'_target_': 'LoadImage'} 2022-11-04 12:16:42,463 - INFO - --- <monai.transforms.io.array.LoadImage object at 0x7f80e2d05790> ``` ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]>
Fixes #5469 ### Description For CrossEntropy, PyTorch v1.10+ allows target values to be either class probabilities or indices, whereas v1.9- only allows for class indices, so class indices are now used. This should provide a better solution for #5393 and remove the need for #5401 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). Signed-off-by: JHancox <[email protected]> Signed-off-by: Behrooz <[email protected]> Co-authored-by: Behrooz <[email protected]>
Fixes #3803 ### Description - fixes lncc loss - adds a cache of the reference grid for `warp` ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: KumoLiu <[email protected]> Fixes #5180. ### Description Add classification post-process script for HoVerNet. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [x] New tests added to cover the changes. - [x] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [x] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: KumoLiu <[email protected]> Signed-off-by: Behrooz <[email protected]> Signed-off-by: monai-bot <[email protected]> Signed-off-by: Wenqi Li <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Behrooz <[email protected]> Co-authored-by: monai-bot <[email protected]> Co-authored-by: Wenqi Li <[email protected]>
Fixes #5431 Fixes #5452 ### Description - deprecating pytorch 1.7 tests - adds pytorch 1.13 tests - upgrade base image to pytorch 22.10 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [x] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]> Fixes #5386 #5387 . ### Description This PR modifies HoverNet via change the kernel size and padding size in order to be consistent with the reference source. This PR also enables to output same shape as the input when using fast mode (takes the conic branch version (see: https://github.com/vqdang/hover_net/tree/conic) for reference). What's more, the functionality of loading pretrained weights is added, users need to add the url which contains the weights that follow the format of the encoder. Finally, this PR adds the `np_out_channels` arg to control the output channels of the nucleus prediction branch. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Yiheng Wang <[email protected]> Co-authored-by: Behrooz Hashemian <[email protected]>
Signed-off-by: Wenqi Li <[email protected]> Fixes #5485 ### Description compatibility torchscript for netadapter also fixes #5487 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]> part of #5394 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. cc @rijobro Signed-off-by: Wenqi Li <[email protected]> Signed-off-by: monai-bot <[email protected]> Co-authored-by: monai-bot <[email protected]>
Fixes #5344 . ### Description This PR implements the metric of Panoptic Quality. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [x] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Yiheng Wang <[email protected]> Co-authored-by: Behrooz Hashemian <[email protected]> Co-authored-by: Dženan Zukić <[email protected]> Co-authored-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]> ### Description adds a paper ref ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description
A few sentences describing the changes proposed in this pull request.
Status
Ready/Work in progress/Hold
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.