FOMOD fixes#23571
Merged
Merged
Conversation
erri120
reviewed
Jun 25, 2026
Comment on lines
+56
to
+62
| "files": [ | ||
| "**/*", | ||
| "!node_modules/@nexusmods/fomod-installer-native/build/**", | ||
| "!node_modules/@nexusmods/fomod-installer-native/bin/**", | ||
| "!node_modules/@nexusmods/fomod-installer-native/src-native/**", | ||
| "!node_modules/@nexusmods/fomod-installer-native/*.{h,lib,dll}" | ||
| ], |
Member
There was a problem hiding this comment.
Don't need this and I really don't more hardcoded paths in configs than necessary.
Member
Author
There was a problem hiding this comment.
Without that we ship redundant files with Native
Member
Author
There was a problem hiding this comment.
About 20MB of redundant files*
Member
Author
There was a problem hiding this comment.
We package those files because we're rebuilding the .node file with electron headers IIRC
Member
Author
There was a problem hiding this comment.
Something is wrong with this. I'll check whether the electron based .node files are shipped and correctly used
IDCs
previously approved these changes
Jun 25, 2026
Removed redundant includes
erri120
approved these changes
Jun 25, 2026
Merged
pull Bot
pushed a commit
to A-Archives-and-Forks/Vortex
that referenced
this pull request
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes LAZ-649