Conversation
only happens if you're installing a mod which has no patches, and already have the same mod installed (but with patches) fixes #19184
The addModRule reducer was ignoring the tag identifier when installing new collections - this would cause the rule to be replaced on previous collections if the mod reference would match. Only reason why this wasn't a problem in past versions is because we used to prompt the user if he wants a new variant or replace the matched mod. testModReference would still fail under any other conditions when trying to differentiate between two binary patched versions of the same mod. fixed the annoying re-download for externally sourced mods as a bonus. fixes #19184 fixes #18878
This was
linked to
issues
Jan 7, 2026
Aragas
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The addModRule reducer was ignoring the tag identifier when installing new collections - this would cause the rule to be replaced on previous collections if the mod reference would match (which it did as the tag was being replaced).
Only reason why this wasn't a problem in past versions is because we used to prompt the user if he wants a new variant of the matched mod.
testModReference would still fail under any other conditions when trying to differentiate between two binary patched versions of the same mod.
fixed the annoying re-download for externally sourced mods as a bonus.
Apparently it fixed collection rule issues when applying to bundled mods too.
fixes #19184
fixes #18878
fixes #18977