Merged
Conversation
- Faster resolution of existing/missing depenendencies upon initial installation of collection - Download queue is now processed every 500 msec and will inform the user of free/occupied download slots - Slow workers (no data reception in the last 5 ticks will get restarted) - Temporary errors such as EIO, ETIMEDOUT, etc will attempt to resume upon failure
Previously restarting a download had the potential of sending an additional api request, trying to resolve the url of a mod
less state manipulation, less overhead
- Improved slow worker restart functionality - Better error handling - Now prioritizing single chunk downloads over multi-chunk
- Also removed the "moved to x" notification (added debug log calls)
Also reduced download speed and update event debouncers for better user feedback on download progress
- Also added cache to avoid duplicate requests
- added proper installation queuing separate from download functionality - better installation tracking to allow for concurrent installations - now properly supports multiple concurrent installations - removed pointless dummy installation queueing
- only keep printable ASCII characters - truncated error meessage just in case - pre-computing hex conversion to avoid potential issues during error creation Please note: the actual issue we want to fix is the LOOT process failing to start, but the error reports are incomplete due to the crash pad and we therefore cannot debug/check why the process dies. We should be able to get the actual error message in future releases. fixes #18251 fixes #18250
fixed potential race condition if update is running but mod was removed
added error details sanitization to prevent crashpad issues
fixed nullish checks in mod reference match tests
…ise-chain fixed inconsistent promise chain potentially raising TypeError
fixed logging attempt of potentially nullish dependency reference
fixed crash if category data is corrupted
…on-download fixed downloads creating folders based on domain rather than internal id
insomnious
previously approved these changes
Sep 15, 2025
The merge-base changed after approval.
insomnious
previously approved these changes
Sep 15, 2025
The merge-base changed after approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.