Wrap hook call in subshell#2
Closed
Ealdwulf wants to merge 1 commit intoNetworkConfiguration:masterfrom
Closed
Conversation
Currently hooks are executed in the same shell. This means that if the hook script executes `exit`, subsequent hooks are not run. The man page doesn't document this behavior - indeed, it says all hooks are run. Wrapping in a subshell should avoid this.
Member
|
I would rather the current behaviour is explicitly documented so that custom enter/exist hooks can affect the variables passed to other hooks. |
Author
|
That's a pity. |
Member
|
This is now documented in d531f8b with a futher commit to fix a spelling mistake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently hooks are executed in the same shell. This means that if the hook script executes
exit, subsequent hooks are not run. The man page doesn't document this behavior - indeed, it says all hooks are run. Wrapping in a subshell should avoid this.This is a behavior change. If it is anticipated that any users utilise this behavior, then it might not be possible to make this change so simply.