Don't merge yet, there are more similar issues. Is there some intention behind this?

Actually, there are still 28 such cases. What's the intention behind this?

Commit 127c06e fixes the remaining cases, just in case you want to merge this change.

@bbczeuz I think the intention was that gcc at the time - or something else I was using many years ago, did the same.
I think I would be happier if we just removed them and maybe prefix with : .... like so

dummy0: executing '/usr/libexec/dhcpcd-run-hooks' CARRIER
dummy0: reading lease `/var/db/dhcpcd/dummy0.lease'

becomes

dummy0: executing: /usr/libexec/dhcpcd-run-hooks CARRIER
dummy0: reading lease: /var/db/dhcpcd/dummy0.lease

Thoughts?

I don't really mind. Quotes suggest a string, but we don't do any escaping anyhow, so it doesn't matter. Do you want me to update the PR to the colon-version (and rebase?)?

It's all a string :)
A lot of BSD tools behave like this, so I fine with it.
If people want to be nutty enough to put a space in the script filename for example, that's up to them.
Note that the SSID used in lease files is escaped so would look like

/var/db/dhcpcd/dummy0\ a\ spaced\ ssid.lease

Although it might escape using octal rather than a space. I've not checked that in a while.

Sure, go head and do it and we'll see about merging it.

I've decided to do this myself as I need to get a release out soon.
Thanks anyway for the patch.