Fix neighbor discovery option parsing#16
Merged
rsmarples merged 2 commits intoNetworkConfiguration:masterfrom May 12, 2020
Merged
Fix neighbor discovery option parsing#16rsmarples merged 2 commits intoNetworkConfiguration:masterfrom
rsmarples merged 2 commits intoNetworkConfiguration:masterfrom
Conversation
The prefix for neighbor discovery options was partially changed to `nd6_` in d5700a4. However set_option_space continued to use `nd_`. This prevented either `nd6_prefix_information` or `nd_prefix_information` from being parsed since the former was in the wrong option space, and the latter did not have the prefix removed.
rsmarples
pushed a commit
that referenced
this pull request
May 12, 2020
* make_option_mask: use `nd_` prefix for nd options The prefix for neighbor discovery options was partially changed to `nd6_` in d5700a4. However set_option_space continued to use `nd_`. This prevented either `nd6_prefix_information` or `nd_prefix_information` from being parsed since the former was in the wrong option space, and the latter did not have the prefix removed. * manual: fix nd_ and dhcp6_ option prefixes
rsmarples
pushed a commit
that referenced
this pull request
May 12, 2020
* make_option_mask: use `nd_` prefix for nd options The prefix for neighbor discovery options was partially changed to `nd6_` in d5700a4. However set_option_space continued to use `nd_`. This prevented either `nd6_prefix_information` or `nd_prefix_information` from being parsed since the former was in the wrong option space, and the latter did not have the prefix removed. * manual: fix nd_ and dhcp6_ option prefixes
rsmarples
pushed a commit
that referenced
this pull request
Jan 25, 2021
* make_option_mask: use `nd_` prefix for nd options The prefix for neighbor discovery options was partially changed to `nd6_` in d5700a4. However set_option_space continued to use `nd_`. This prevented either `nd6_prefix_information` or `nd_prefix_information` from being parsed since the former was in the wrong option space, and the latter did not have the prefix removed. * manual: fix nd_ and dhcp6_ option prefixes
rsmarples
pushed a commit
that referenced
this pull request
Apr 8, 2021
* make_option_mask: use `nd_` prefix for nd options The prefix for neighbor discovery options was partially changed to `nd6_` in d5700a4. However set_option_space continued to use `nd_`. This prevented either `nd6_prefix_information` or `nd_prefix_information` from being parsed since the former was in the wrong option space, and the latter did not have the prefix removed. * manual: fix nd_ and dhcp6_ option prefixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
See commit message for details