Linux: fix RA time unit confusion#12
Merged
rsmarples merged 1 commit intoNetworkConfiguration:masterfrom Jan 1, 2020
Merged
Conversation
The RA times are provided in milliseconds, but commit 569051c (dhcpcd-8.1.3~18) “Linux: prefer ms RA times” incorrectly scaled them by an extra factor of 1000 before writing them to retrans_time_ms and base_reachable_time_ms. Instead, write the values in milliseconds directly to the *_ms files, and correctly convert to jiffies or seconds for the other files if necessary. Fixes NixOS/nixpkgs#76710. Signed-off-by: Anders Kaseorg <[email protected]>
10 tasks
Member
andersk
added a commit
to andersk/nixpkgs
that referenced
this pull request
Jan 1, 2020
Fixes NixOS#76710. Submitted upstream as NetworkConfiguration/dhcpcd#12. Signed-off-by: Anders Kaseorg <[email protected]>
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Jan 2, 2020
Fixes NixOS#76710. Submitted upstream as NetworkConfiguration/dhcpcd#12. Signed-off-by: Anders Kaseorg <[email protected]> (cherry picked from commit e474db2)
rsmarples
added a commit
that referenced
this pull request
Jan 25, 2021
The RA times are provided in milliseconds, but commit 569051c (dhcpcd-8.1.3~18) “Linux: prefer ms RA times” incorrectly scaled them by an extra factor of 1000 before writing them to retrans_time_ms and base_reachable_time_ms. Instead, write the values in milliseconds directly to the *_ms files, and correctly convert to jiffies or seconds for the other files if necessary. Signed-off-by: Anders Kaseorg <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RA times are provided in milliseconds, but commit 569051c (dhcpcd-8.1.3~18) “Linux: prefer ms RA times” incorrectly scaled them by an extra factor of 1000 before writing them to
retrans_time_msandbase_reachable_time_ms. Instead, write the values in milliseconds directly to the*_msfiles, and correctly convert to jiffies or seconds for the other files if necessary.Fixes NixOS/nixpkgs#76710.