Use application/json as content type when returning credentials#115
Merged
patricksanders merged 1 commit intoNetflix:masterfrom Mar 17, 2022
Merged
Use application/json as content type when returning credentials#115patricksanders merged 1 commit intoNetflix:masterfrom
patricksanders merged 1 commit intoNetflix:masterfrom
Conversation
Contributor
|
I misled you with my recommendation earlier. 🤦 I just pushed a change to your branch that moves the header setting into both (IMDS and ECS) credential handlers. I still need to update/add tests for the changed functionality, but manual testing showed success. |
Use application/json as content type when returning credentials The credentials are returned as a JSON object so update the content type to match instead of text/plain. move content-type to handlers for cred endpoints update pre-commit config to use https for git, remove content-type check from test set content-type in handlers instead of middleware
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The credentials are returned as a JSON object so update the content type
to match instead of text/plain.