Skip to content

fix: corrected package name typo in MutableStep flow type hint#3183

Merged
talsperre merged 1 commit into
Netflix:masterfrom
agsaru:user_decorators
May 7, 2026
Merged

fix: corrected package name typo in MutableStep flow type hint#3183
talsperre merged 1 commit into
Netflix:masterfrom
agsaru:user_decorators

Conversation

@agsaru

@agsaru agsaru commented May 7, 2026

Copy link
Copy Markdown
Contributor

PR Type

  • Bug fix
  • New feature
  • Core Runtime change (higher bar -- see CONTRIBUTING.md)
  • Docs / tooling
  • Refactoring

Summary

This PR fixes a typo in the type hint for the flow property in the mutable_step.py file.

Copilot AI review requested due to automatic review settings May 7, 2026 18:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an incorrect fully-qualified module path in the MutableStep.flow return type annotation, aligning the type hint with the actual metaflow.user_decorators package structure.

Changes:

  • Corrected the MutableStep.flow type hint from metaflow.user_decorator... to metaflow.user_decorators....

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@greptile-apps

greptile-apps Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Corrects a one-character typo in the forward-reference string used as the return type hint for MutableStep.flow. The old string "metaflow.user_decorator.mutable_flow.MutableFlow" referenced a non-existent package (user_decorator instead of user_decorators), which would cause static analysis tools and IDEs to fail to resolve the type.

  • Fixes the return type annotation on MutableStep.flow from metaflow.user_decorator.mutable_flow.MutableFlow to metaflow.user_decorators.mutable_flow.MutableFlow, aligning it with the actual module path.

Confidence Score: 5/5

Single-line string correction in a type hint with no runtime impact; safe to merge.

The change touches only a forward-reference string used for static analysis. Runtime behavior is completely unaffected, and the corrected path matches the actual directory layout of the package.

No files require special attention.

Important Files Changed

Filename Overview
metaflow/user_decorators/mutable_step.py Fixed typo in the flow property's return type hint string: user_decoratoruser_decorators, matching the actual package path.

Reviews (1): Last reviewed commit: "corrected package typo" | Re-trigger Greptile

@talsperre
talsperre merged commit 2d42436 into Netflix:master May 7, 2026
40 of 42 checks passed
@codecov

codecov Bot commented May 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@ae9420e). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3183   +/-   ##
=========================================
  Coverage          ?   28.29%           
=========================================
  Files             ?      381           
  Lines             ?    52343           
  Branches          ?     9238           
=========================================
  Hits              ?    14808           
  Misses            ?    36597           
  Partials          ?      938           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants