Skip to content

fix: Added missing targets to .PHONY and removed duplicates#3168

Merged
npow merged 1 commit into
Netflix:masterfrom
agsaru:phony
Apr 30, 2026
Merged

fix: Added missing targets to .PHONY and removed duplicates#3168
npow merged 1 commit into
Netflix:masterfrom
agsaru:phony

Conversation

@agsaru

@agsaru agsaru commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

PR Type

  • Bug fix
  • New feature
  • Core Runtime change (higher bar -- see CONTRIBUTING.md)
  • Docs / tooling
  • Refactoring

Summary

This PR updates the .PHONY in the Makefile.
Added missing targets wait-until-ready and create-dev-shell to the .PHONY .
And removed duplicates up and down from the .PHONY.

Copilot AI review requested due to automatic review settings April 30, 2026 05:01
@greptile-apps

greptile-apps Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes the .PHONY declaration in devtools/Makefile by adding the two previously missing targets (wait-until-ready and create-dev-shell) and deduplicating the double-listed up and down entries. Every target defined in the Makefile is now listed exactly once in .PHONY.

Confidence Score: 5/5

Safe to merge — a small, correct .PHONY bookkeeping fix with no functional risk.

All 18 Makefile targets are now listed exactly once in .PHONY; the added targets (wait-until-ready, create-dev-shell) are verified to exist in the file, and the removed duplicates (up, down) are still present once each. No logic was changed.

No files require special attention.

Important Files Changed

Filename Overview
devtools/Makefile .PHONY corrected: added missing wait-until-ready and create-dev-shell targets (both defined in the file), removed the duplicate up and down entries; all 18 defined targets are now listed exactly once.

Reviews (1): Last reviewed commit: "Added missing targets to .PHONY" | Re-trigger Greptile

Copilot AI reviewed Apr 30, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the .PHONY declaration in devtools/Makefile to accurately reflect the set of non-file make targets used by the devtools workflow.

Changes:

  • Added missing phony targets: wait-until-ready and create-dev-shell.
  • Removed duplicate entries for up and down.
  • Reordered the .PHONY target list for clarity.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Apr 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@f357565). Learn more about missing BASE report.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #3168   +/-   ##
=========================================
  Coverage          ?   27.17%           
=========================================
  Files             ?      375           
  Lines             ?    51746           
  Branches          ?     9143           
=========================================
  Hits              ?    14063           
  Misses            ?    36783           
  Partials          ?      900

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@npow
npow merged commit b7e8f88 into Netflix:master Apr 30, 2026
44 of 45 checks passed
agsaru added a commit to agsaru/metaflow that referenced this pull request May 1, 2026
@agsaru
fix: Added missing targets to .PHONY and removed duplicates (Netflix#…
3a9ff8e 
…3168)

## PR Type

<!-- Check one -->

- [x] Bug fix
- [ ] New feature
- [ ] Core Runtime change (higher bar -- see
[CONTRIBUTING.md](../CONTRIBUTING.md#core-runtime-contributions-higher-bar))
- [ ] Docs / tooling
- [ ] Refactoring

## Summary

<!-- What user-visible behavior changes? 1-2 sentences. -->
This PR updates the `.PHONY` in the `Makefile`.
Added missing targets `wait-until-ready` and `create-dev-shell` to the
`.PHONY` .
And removed duplicates `up` and `down` from the `.PHONY`.
@agsaru
agsaru deleted the phony branch June 1, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@agsaru @npow