Removed the duplicate and unused pretty_print function#3133
Conversation
Greptile SummaryThis PR removes the first (older) Confidence Score: 5/5Safe to merge — simple dead-code removal with no functional impact. Only one file changed, the removed function was a strict subset of the retained one, and the call-site is unaffected. No P0/P1 findings. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "Removed the duplicate and unused pretty_..." | Re-trigger Greptile |
There was a problem hiding this comment.
Pull request overview
Removes a duplicate pretty_print implementation in devtools/pick_services.sh to avoid having one function definition silently overwrite another, leaving a single canonical formatting helper used by the script.
Changes:
- Deleted the older, duplicate
pretty_printfunction definition. - Keeps the updated
pretty_printimplementation as the single source of truth.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3133 +/- ##
=========================================
Coverage ? 26.07%
=========================================
Files ? 375
Lines ? 51435
Branches ? 9071
=========================================
Hits ? 13414
Misses ? 37235
Partials ? 786 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
## PR Type <!-- Check one --> - [x] Bug fix - [ ] New feature - [ ] Core Runtime change (higher bar -- see [CONTRIBUTING.md](../CONTRIBUTING.md#core-runtime-contributions-higher-bar)) - [ ] Docs / tooling - [ ] Refactoring ## Summary There are two `pretty_print` functions in the `pick_services.sh` file. The second functions is updated version of the first one. And also the the second one overwrites the first one.
PR Type
Summary
There are two
pretty_printfunctions in thepick_services.shfile. The second functions is updated version of the first one. And also the the second one overwrites the first one.