validation of sample flow with mypy + packaging#1676
Merged
romain-intel merged 16 commits intoNetflix:feat/stubs-generator-cmdfrom Jan 17, 2024
Merged
validation of sample flow with mypy + packaging#1676romain-intel merged 16 commits intoNetflix:feat/stubs-generator-cmdfrom
romain-intel merged 16 commits intoNetflix:feat/stubs-generator-cmdfrom
Conversation
mt-ob
force-pushed
the
stubs-validation
branch
from
a2375f5 to
5d551e6
Compare
mt-ob
changed the title
romain-intel
force-pushed
the
feat/stubs-generator-cmd
branch
from
87e81a9 to
1a627ca
Compare
mt-ob
force-pushed
the
stubs-validation
branch
from
699b365 to
dea8223
Compare
mt-ob
commented
Jan 16, 2024
stubs/test/test_stubs.yml
Outdated
| ... | ||
| out: | | ||
| main:3: error: Argument 1 to "conda" has incompatible type "type[NonFlowDecorator]"; expected "dict[str, str]" [arg-type] | ||
| main:4: error: Too many positional arguments for "conda" [misc] |
Collaborator
Author
There was a problem hiding this comment.
@romain-intel the conda decorator probably has some issues with mypy
mt-ob
commented
Jan 16, 2024
stubs/test/test_stubs.yml
Outdated
|
|
||
| @conda | ||
| @step | ||
| def wrong_no_arg(self): |
Collaborator
Author
There was a problem hiding this comment.
@romain-intel this case shouldn't have been wrong...
romain-intel
added a commit
that referenced
this pull request
Jan 23, 2024
* Added a stub command; moved script to new location. * validation of sample flow with mypy + packaging (#1676) * validate sample flow with mypy * also install metaflow in CI * change commands * package generated stubs with metaflow * don't do editable install * re-introduce setup.py * update publish action * point to dist * check common cases with pytest-mypy plugin * Updated stub tests; added kw only args to stub generator * remove test flow * kubernetes validity * add tests for environment, card, catch, conda * add tests for timeout, secrets, retry, resources decorators * add tests for conda_base, schedule, trigger, trigger_on_finish decorators * Get tests to pass again --------- Co-authored-by: Romain Cledat <[email protected]> * fix checking of stubs package (#1689) * Properly uninstall packages that provide stubs before installing a new one. * Add a few more cases to the stub generator * add tests for pypi and pypi_base decorators (#1694) * Remove print; better setup.py --------- Co-authored-by: madhur-ob <[email protected]>
romain-intel
added a commit
that referenced
this pull request
Jan 29, 2024
* Fix some docstrings and add Add To Current * Docstring changes * More docstrings * Stub generator script * More docstring fixes * Improve stub generator script Now: - deals with static and class methods - better handling of forward types or types and files with __annotations__ - better handling of default values * Add specialized function in the client to get proper return types * Fix invalid docstrings * Fixup more stuff in stub generator * make docstrings consistent * Small fixes * Move current.py to metaflow_current.py * Minor tweaks * Added MANIFEST.in * Fix issues with numpydoc compilation * Updated stub generator to include step and type check decorators better * Addressed comments * Added a stub command; moved script to new location. (#1682) * Added a stub command; moved script to new location. * validation of sample flow with mypy + packaging (#1676) * validate sample flow with mypy * also install metaflow in CI * change commands * package generated stubs with metaflow * don't do editable install * re-introduce setup.py * update publish action * point to dist * check common cases with pytest-mypy plugin * Updated stub tests; added kw only args to stub generator * remove test flow * kubernetes validity * add tests for environment, card, catch, conda * add tests for timeout, secrets, retry, resources decorators * add tests for conda_base, schedule, trigger, trigger_on_finish decorators * Get tests to pass again --------- Co-authored-by: Romain Cledat <[email protected]> * fix checking of stubs package (#1689) * Properly uninstall packages that provide stubs before installing a new one. * Add a few more cases to the stub generator * add tests for pypi and pypi_base decorators (#1694) * Remove print; better setup.py --------- Co-authored-by: madhur-ob <[email protected]> * Small fixes to be better with PyCharm * Example test with more flexible verification for mypy * use regex for mypy tests (#1697) * use regex for mypy tests * fix regex * edit testing CI (#1699) * separate workflow for testing stubs (#1701) * separate workflow for testing stubs * remove 3.5 and 3.6 * fix test stubs workflow (#1702) * install build via pip * install pytest * add timeout (#1703) * remove on_retry_command * Fix issue with stub generator for TypeVar * Add extra requires to main setup.py * publish stubs package before (#1705) * Change color of 'valid' --------- Co-authored-by: Ville Tuulos <[email protected]> Co-authored-by: madhur-ob <[email protected]> Co-authored-by: Madhur Tandon <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.