lsp: add Language Server Protocol module#1888
Merged
brharrington merged 4 commits intoNetflix:mainfrom Mar 25, 2026
Merged
Conversation
Add atlas-lsp module implementing LSP for Atlas Stack Language and graph URI documents. Provides real-time editor support including diagnostics, completions, hover, semantic tokens, code actions, document symbols, and go-to-definition. Two server variants: - AslLspServer for standalone ASL expressions - UriLspServer for graph API URIs with embedded expressions Key components: - AslDocumentAnalyzer: expression analysis with typed parameter diagnostics, word completions, glossary integration, format/ normalize/compress code actions, and semantic highlighting - UriDocumentAnalyzer: URI-aware wrapper that parses query parameters, delegates expression analysis to ASL, and shifts positions between raw/decoded/URI coordinate spaces - Glossary: JSON-driven metric and tag key documentation for hover and completion enrichment - AslTokenTypes: semantic token type mapping for LSP Java classes are used for LSP4j server interfaces due to annotation interop requirements with the LSP4j framework. Includes a Monaco-based test client for browser testing.
Removed the TODO section outlining future enhancements and features.
a24e6cf to
a47ae07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add atlas-lsp module implementing LSP for Atlas Stack Language and graph URI documents. Provides real-time editor support including diagnostics, completions, hover, semantic tokens, code actions, document symbols, and go-to-definition.
Two server variants:
Key components:
Java classes are used for LSP4j server interfaces due to annotation interop requirements with the LSP4j framework.
Includes a Monaco-based test client for browser testing.