core: fix lessThan matching in RoaringTagIndex#1880
Merged
brharrington merged 1 commit intoNetflix:mainfrom Feb 28, 2026
Merged
core: fix lessThan matching in RoaringTagIndex#1880brharrington merged 1 commit intoNetflix:mainfrom
brharrington merged 1 commit intoNetflix:mainfrom
Conversation
tagOffset returns the insertion point (first element greater than the target) when a tag is not found. The lessThan method iterates backward from this position, but was incorrectly starting at the insertion point itself, which could include values that are not actually less than the query value. This occurs when the global values array contains values from other keys that cause the computed value position to not exist as a tag for the queried key. For example, nf.asg,a,:lt could incorrectly match "a1javasandbox-v008" because the backward iteration started one position too far forward. The fix adjusts the starting position when the tag at the insertion point is greater than the target, stepping back to the last element <= the target before iterating.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tagOffset returns the insertion point (first element greater than the target) when a tag is not found. The lessThan method iterates backward from this position, but was incorrectly starting at the insertion point itself, which could include values that are not actually less than the query value.
This occurs when the global values array contains values from other keys that cause the computed value position to not exist as a tag for the queried key. For example, nf.asg,a,:lt could incorrectly match "a1javasandbox-v008" because the backward iteration started one position too far forward.
The fix adjusts the starting position when the tag at the insertion point is greater than the target, stepping back to the last element <= the target before iterating.