Backport recent changes to 1.8.x#1874
Merged
brharrington merged 4 commits intoNetflix:v1.8.xfrom Feb 24, 2026
Merged
Conversation
Ensures it will get logged and be easier to debug. If relying on the caller it might get burried in the pekko plumbing.
When subscription delivery is delayed (e.g., due to staggered broadcast), the websocket connection could hit the idle timeout before any data flows. This was because the data source (including heartbeats) was not pushed downstream until the client sent its first subscription message. - Push the data source on the first downstream pull instead of waiting for a client message, so heartbeats flow as soon as the websocket connects. - Emit a default heartbeat with a 5s step when no subscriptions are established yet. Once subscriptions arrive, the real step-based heartbeats take over on the next tick. - Add debug logging for staggered broadcast delay.
Allow the set of cluster members to be updated even if the downstream is still working based on the injected delays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.