eval: improve simple legend handling for rewrites#1854
Merged
brharrington merged 2 commits intoNetflix:mainfrom Jan 31, 2026
Merged
eval: improve simple legend handling for rewrites#1854brharrington merged 2 commits intoNetflix:mainfrom
brharrington merged 2 commits intoNetflix:mainfrom
Conversation
Update the simple legend handling to better handle named rewrite use-cases other than average. It will now treat all aggregate functions the same rather than special cases `-avg` operations. Others will use the display expression for the purpose of determing the legend.
Contributor
|
LGTM! Thanks for the fix and the guidance. On our side, I've simplified the ODL macros to just use With both changes, the SimpleLegends issue is resolved. |
dmuino
approved these changes
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the simple legend handling to better handle named rewrite use-cases other than average. It will now treat all aggregate functions the same rather than special cases
-avgoperations. Others will use the display expression for the purpose of determing the legend.