core: add sample-count operation#1592
Merged
brharrington merged 1 commit intoNetflix:mainfrom Dec 13, 2023
Merged
Conversation
Adds a `sample-count` operation that can be used to estimate the number of samples received for a percentile approximation baed on a range of the distribution. This estimate is computed by adjusting the query to restrict the set of buckets used to model the distribution to those for the specified range. One use-case for this is to be able to track number of requests that are not within an SLO based on latency. If more precise tracking is needed, then a bucket counter could be used with a bucket boundary that matches the SLO threshold. However, this operation can be used to get an estimate if an existing percentile timer exists.
manolama
pushed a commit
to manolama/atlas
that referenced
this pull request
May 22, 2024
Adds a `sample-count` operation that can be used to estimate the number of samples received for a percentile approximation baed on a range of the distribution. This estimate is computed by adjusting the query to restrict the set of buckets used to model the distribution to those for the specified range. One use-case for this is to be able to track number of requests that are not within an SLO based on latency. If more precise tracking is needed, then a bucket counter could be used with a bucket boundary that matches the SLO threshold. However, this operation can be used to get an estimate if an existing percentile timer exists. For now this operation is marked as unstable to allow for some broader testing. There may still be some adjustments to the naming and behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
sample-countoperation that can be used to estimate the number of samples received for a percentile approximation baed on a range of the distribution. This estimate is computed by adjusting the query to restrict the set of buckets used to model the distribution to those for the specified range.One use-case for this is to be able to track number of requests that are not within an SLO based on latency. If more precise tracking is needed, then a bucket counter could be used with a bucket boundary that matches the SLO threshold. However, this operation can be used to get an estimate if an existing percentile timer exists.
For now this operation is marked as unstable to allow for some broader testing. There may still be some adjustments to the naming and behavior.