eval: ensure exprs are resent on reconnect#1557
Merged
brharrington merged 1 commit intoNetflix:mainfrom May 27, 2023
Merged
Conversation
If the websocket to an lwcapi node fails and needs to reconnect, then the message with the set of expressions needs to be resent. Before this would only happen when there was a change in either the set of remote instances or the set of expressions. With this change, the set of expressions will get repeated every 5s so it will get resent on a reconnect. Note, the websocket sub-flow already has some deduping if there is no change, so the additional overhead during normal operations is minimal. If there is a failure, then the sub-flow will get restarted and the state for the `unique` operator will get reset allowing the repeated expression message through.
manolama
pushed a commit
to manolama/atlas
that referenced
this pull request
May 22, 2024
If the websocket to an lwcapi node fails and needs to reconnect, then the message with the set of expressions needs to be resent. Before this would only happen when there was a change in either the set of remote instances or the set of expressions. With this change, the set of expressions will get repeated every 5s so it will get resent on a reconnect. Note, the websocket sub-flow already has some deduping if there is no change, so the additional overhead during normal operations is minimal. If there is a failure, then the sub-flow will get restarted and the state for the `unique` operator will get reset allowing the repeated expression message through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the websocket to an lwcapi node fails and needs to reconnect, then the message with the set of expressions needs to be resent. Before this would only happen when there was a change in either the set of remote instances or the set of expressions. With this change, the set of expressions will get repeated every 5s so it will get resent on a reconnect.
Note, the websocket sub-flow already has some deduping if there is no change, so the additional overhead during normal operations is minimal. If there is a failure, then the sub-flow will get restarted and the state for the
uniqueoperator will get reset allowing the repeated expression message through.