adjust heatmap scale behavior#1551
Merged
brharrington merged 1 commit intoNetflix:mainfrom May 9, 2023
Merged
Conversation
Changes the min to be the minimum non-zero count for a cell, or zero if there is no data. Updates the color scale to use the actual min/max or the bounds. Before it was using zero even if an explicit lower bound was selected. Further, using the min non-zero count and max count as the range spreads the colors better over the data range. This also removes the max behavior of rounding to one significant digit. That rounding would lead to tick values that were easier to reason about, but it could roung by a large amount relative to the data causing most data to go to a single color cell. Will revisit in the future for achieving more significant tick boundaries with less downsides. Some minor fixes to the inverted scale logic for the log-linear scale.
manolama
approved these changes
May 9, 2023
manolama
pushed a commit
to manolama/atlas
that referenced
this pull request
May 22, 2024
Changes the min to be the minimum non-zero count for a cell, or zero if there is no data. Updates the color scale to use the actual min/max or the bounds. Before it was using zero even if an explicit lower bound was selected. Further, using the min non-zero count and max count as the range spreads the colors better over the data range. This also removes the max behavior of rounding to one significant digit. That rounding would lead to tick values that were easier to reason about, but it could round by a large amount relative to the data causing most data to go to a single color cell. Will revisit in the future for achieving more significant tick boundaries with less downsides. Some minor fixes to the inverted scale logic for the log-linear scale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the min to be the minimum non-zero count for a cell, or zero if there is no data. Updates the color scale to use the actual min/max or the bounds. Before it was using zero even if an explicit lower bound was selected. Further, using the min non-zero count and max count as the range spreads the colors better over the data range.
This also removes the max behavior of rounding to one significant digit. That rounding would lead to tick values that were easier to reason about, but it could round by a large amount relative to the data causing most data to go to a single color cell. Will revisit in the future for achieving more significant tick boundaries with less downsides.
Some minor fixes to the inverted scale logic for the log-linear scale.