Repository navigation
fix(weapp): support phone number quota toast prop - #19493
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⛔ Files ignored due to path filters (13)
⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (13)
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. Walkthrough新增 Changes手机号额度提示支持
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This change lets WeChat mini-program buttons suppress the default phone-number quota toast when explicitly requested, without changing phone-number access or existing behavior for callers that omit the option. No actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 小兔捧来一个新开关 Comment |
|
你好,测试没过需要修复一下 |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (54.63%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #19493 +/- ##
========================================
Coverage 54.63% 54.63%
========================================
Files 465 465
Lines 25392 25392
Branches 6376 6341 -35
========================================
Hits 13873 13873
+ Misses 9640 9502 -138
- Partials 1879 2017 +138
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
92f9a3d to
bc06640
Compare
这个 PR 做了什么? (简要描述所做更改)
Fixes #15845.
ButtonProps补充微信小程序phoneNumberNoQuotaToast?: boolean类型声明。phone-number-no-quota-toast,默认值保持微信基础库的true。open-type="getPhoneNumber"或open-type="getRealtimePhoneNumber"时生效,允许业务在额度用尽时关闭平台默认提示并自行处理错误码。官方文档:https://developers.weixin.qq.com/miniprogram/dev/component/button
验证
corepack pnpm lintcorepack pnpm --filter @tarojs/plugin-platform-weapp run buildcorepack pnpm --filter @tarojs/components run build:ciphoneNumberNoQuotaToast接受 boolean,并拒绝 stringphone-number-no-quota-toast,且默认值为true@tarojs/componentsspec:70 suites / 106 tests / 35 snapshots 全部通过补充:全量 e2e 在本机 Chrome 上仍有与本改动无关的既有差异(CSS
transition序列化、页面 hydration 超时与 focus/blur 次数差异),未更新任何快照。这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台:
Summary by CodeRabbit
phoneNumberNoQuotaToast控制是否显示平台默认提示;默认开启,仅适用于微信小程序。