Python versions iso_dateformat scenario#47
Conversation
|
Hi @SoyGema , thank you again for your help! For tests conditioned by the Python version number, you can use the To be able to use the However, not all users need this dependency, only users with a version prior to Python 3.11. To do this, the best thing would be to include a line like the following: I have seen that the GitHub Actions lint is failing due to black validation. Remember to run I know it's a lot to do, but don't worry, we're almost done. I think this should be all we need for the Pull Request. Likewise, I hope I was able to help, if you have any questions, let me know. Thanks for your contribution! Marty: Doc: Marty: Doc: Marty: Doc: Marty: Doc: Marty: |
|
Hey!
Can you take care of black ? Can you please send me more information about this so I can learn ? black is some sort of prettier reformat ? |
Yes, this is correct :) Remember that after adding the dependency to the Black is a tool that checks if the code complies with the style guide. It automatically rewrites the code if it detects invalid code. You have integrations for different IDEs, but you can also run it manually using: Install it using |
|
Hello there @Nekmo ! As noted, I runed It´s so exciting this is moving forward! Learned a few things thanks to this PR, so thanks for giving me the opportunity to contribute. Thanks also for your guidance and support. Your empathy toward supporting contributors' growth affirms your commitment to the community.
|
|
Many thanks to you @SoyGema for your help! I'm glad to know that the experience has helped you :) I've re-run the tests for the PR, and as far as I can tell, black would need to be run on the files I need to check how to enable Github Actions tests for Pull Requests... Sorry for the inconvenience! Marty: |
|
Everything is fine, thanks! It's already merged :) I hope to be able to count on you in the future. Doc: Marty: |
|
@SoyGema I have added you to the collaborators file. If you want me to remove you, let me know and I'll remove you :) |
Hey Thanks! That means a lot 🥹 |



What does this PR do?
Thanks for creating
pip-ratingand for the 𝚝𝚒𝚖𝚎 𝚝𝚛𝚊𝚟𝚎𝚕ride.
This pull request aims to Fix #46
It includes a script called
utils.pythat definesparse_iso_datetime,converting date inside a Python-dependent scenario.
It includes the function
parse_iso_datetimeintorating.pyIr drafts a discussion / ask for help about tests
Read the contributor guideline
Discussed with maintainer
Does this PR have tests ?
Tests
It would be amazing if you could give me a helping hand with this.
Please note my limited experience on this, as I'm used to putting examples for the test and I don´t know if is better to have another abstraction layer.
🙏Thanks in advance for your empathy on this dimension. 🙏
Happy if I could learn more about this!
So the approach that I would do is, add this code under
tests>source>test_rating.pyPossible discussions
utils.pyunderpip_rating? Unclear to me at some point if it could be insourcesLore Follow up
𝙼𝚊𝚛𝚝𝚢: 𝙳𝚘𝚌, 𝚝𝚑𝚒𝚜 𝙸𝚂𝙾 𝚍𝚊𝚝𝚎 𝚏𝚘𝚛𝚖𝚊𝚝 𝚝𝚑𝚒𝚗𝚐 𝚒𝚜 𝚍𝚛𝚒𝚟𝚒𝚗𝚐 𝚖𝚎 𝚗𝚞𝚝𝚜! 𝚂𝚘𝚖𝚎𝚝𝚒𝚖𝚎𝚜 𝚒𝚝'𝚜 '𝟸0𝟸𝟹-0𝟿-𝟷𝟺𝚃𝟷𝟾:𝟻𝟼:𝟸𝟿.𝟽0𝟸𝟿00𝚉,' 𝚊𝚗𝚍 𝚘𝚝𝚑𝚎𝚛 𝚝𝚒𝚖𝚎𝚜, 𝚒𝚝'𝚜 𝚓𝚞𝚜𝚝 '𝟸0𝟸𝟹-0𝟿-𝟷𝟺𝚃𝟷𝟾:𝟻𝟼:𝟸𝟿𝚉'! 𝙷𝚘𝚠 𝚍𝚘 𝙸 𝚎𝚟𝚎𝚗 𝚙𝚊𝚛𝚜𝚎 𝚝𝚑𝚒𝚜?
𝙳𝚘𝚌: 𝙶𝚛𝚎𝚊𝚝 𝚂𝚌𝚘𝚝𝚝, 𝙼𝚊𝚛𝚝𝚢! 𝙸𝚝'𝚜 𝚕𝚒𝚔𝚎 𝚠𝚎'𝚛𝚎 𝚍𝚎𝚊𝚕𝚒𝚗𝚐 𝚠𝚒𝚝𝚑 𝚝𝚒𝚖𝚎 𝚝𝚛𝚊𝚟𝚎𝚕 𝚑𝚎𝚛𝚎. 𝚈𝚘𝚞 𝚜𝚎𝚎, 𝚒𝚗 𝙿𝚢𝚝𝚑𝚘𝚗, 𝚒𝚝'𝚜 𝚊𝚕𝚕 𝚊𝚋𝚘𝚞𝚝 𝚍𝚒𝚏𝚏𝚎𝚛𝚎𝚗𝚝 𝚟𝚎𝚛𝚜𝚒𝚘𝚗𝚜 𝚊𝚗𝚍 𝚍𝚊𝚝𝚎 𝚏𝚘𝚛𝚖𝚊𝚝𝚜. 𝙸𝚗 𝚝𝚑𝚎 𝚙𝚊𝚜𝚝, 𝚝𝚑𝚎𝚢 𝚍𝚒𝚍𝚗'𝚝 𝚑𝚊𝚟𝚎 𝚝𝚑𝚎 𝚏𝚊𝚗𝚌𝚢 𝚏𝚛𝚘𝚖𝚒𝚜𝚘𝚏𝚘𝚛𝚖𝚊𝚝, 𝚊𝚗𝚍 𝚝𝚑𝚎𝚢 𝚞𝚜𝚎𝚍 𝚝𝚑𝚎 𝚍𝚊𝚝𝚎𝚞𝚝𝚒𝚕 𝚕𝚒𝚋𝚛𝚊𝚛𝚢 𝚝𝚘 𝚖𝚊𝚔𝚎 𝚜𝚎𝚗𝚜𝚎 𝚘𝚏 𝚒𝚝 𝚊𝚕𝚕.
𝙼𝚊𝚛𝚝𝚢: 𝚂𝚘, 𝚠𝚑𝚊𝚝 𝚍𝚘 𝙸 𝚍𝚘 𝚗𝚘𝚠? 𝙸 𝚍𝚘𝚗'𝚝 𝚠𝚊𝚗𝚝 𝚝𝚘 𝚋𝚛𝚎𝚊𝚔 𝚝𝚑𝚎 𝚜𝚙𝚊𝚌𝚎-𝚝𝚒𝚖𝚎 𝚌𝚘𝚗𝚝𝚒𝚗𝚞𝚞𝚖!
𝙳𝚘𝚌: 𝙳𝚘𝚗'𝚝 𝚠𝚘𝚛𝚛𝚢, 𝙼𝚊𝚛𝚝𝚢. 𝚆𝚎'𝚟𝚎 𝚐𝚘𝚝 𝚊 𝚌𝚘𝚗𝚍𝚒𝚝𝚒𝚘𝚗𝚊𝚕 𝚝𝚒𝚖𝚎 𝚖𝚊𝚌𝚑𝚒𝚗𝚎 – 𝙸 𝚖𝚎𝚊𝚗, 𝚌𝚘𝚍𝚎 – 𝚝𝚑𝚊𝚝 𝚌𝚑𝚎𝚌𝚔𝚜 𝚢𝚘𝚞𝚛 𝙿𝚢𝚝𝚑𝚘𝚗 𝚟𝚎𝚛𝚜𝚒𝚘𝚗 𝚊𝚗𝚍 𝚙𝚒𝚌𝚔𝚜 𝚝𝚑𝚎 𝚛𝚒𝚐𝚑𝚝 𝚖𝚎𝚝𝚑𝚘𝚍. 𝙸𝚏 𝚢𝚘𝚞'𝚛𝚎 𝚒𝚗 𝙿𝚢𝚝𝚑𝚘𝚗 𝟹.𝟷𝟷 𝚘𝚛 𝚑𝚒𝚐𝚑𝚎𝚛, 𝚒𝚝 𝚐𝚘𝚎𝚜 '𝚏𝚛𝚘𝚖𝚒𝚜𝚘𝚏𝚘𝚛𝚖𝚊𝚝' 𝚍𝚒𝚛𝚎𝚌𝚝𝚕𝚢. 𝙵𝚘𝚛 𝚘𝚕𝚍𝚎𝚛 𝚟𝚎𝚛𝚜𝚒𝚘𝚗𝚜, 𝚒𝚝 𝚝𝚛𝚒𝚎𝚜 '𝚏𝚛𝚘𝚖𝚒𝚜𝚘𝚏𝚘𝚛𝚖𝚊𝚝' 𝚏𝚒𝚛𝚜𝚝 𝚊𝚗𝚍 𝚝𝚑𝚎𝚗 𝚏𝚊𝚕𝚕𝚜 𝚋𝚊𝚌𝚔 𝚝𝚘 𝚍𝚊𝚝𝚎𝚞𝚝𝚒𝚕.
𝙼𝚊𝚛𝚝𝚢: 𝚃𝚑𝚊𝚝'𝚜 𝚑𝚎𝚊𝚟𝚢, 𝙳𝚘𝚌. 𝙱𝚞𝚝 𝚠𝚑𝚊𝚝 𝚊𝚋𝚘𝚞𝚝 𝚝𝚑𝚎 𝚏𝚞𝚝𝚞𝚛𝚎?
𝙳𝚘𝚌: 𝙸𝚗 𝚝𝚑𝚎 𝚏𝚞𝚝𝚞𝚛𝚎, 𝚠𝚑𝚎𝚗 𝚎𝚟𝚎𝚛𝚢𝚘𝚗𝚎'𝚜 𝚘𝚗 𝙿𝚢𝚝𝚑𝚘𝚗 𝟹.𝟷𝟷 𝚘𝚛 𝚑𝚒𝚐𝚑𝚎𝚛, 𝚢𝚘𝚞 𝚌𝚊𝚗 𝚍𝚒𝚝𝚌𝚑 𝚝𝚑𝚎 𝚏𝚊𝚕𝚕𝚋𝚊𝚌𝚔 𝚌𝚘𝚍𝚎. 𝚄𝚗𝚝𝚒𝚕 𝚝𝚑𝚎𝚗, 𝚓𝚞𝚜𝚝 𝚔𝚎𝚎𝚙 𝚝𝚑𝚎 𝙳𝚎𝙻𝚘𝚛𝚎𝚊𝚗 – 𝙸 𝚖𝚎𝚊𝚗, 𝚌𝚘𝚍𝚎 – 𝚛𝚞𝚗𝚗𝚒𝚗𝚐 𝚜𝚖𝚘𝚘𝚝𝚑𝚕𝚢.
𝙼𝚊𝚛𝚝𝚢: 𝚃𝚑𝚊𝚗𝚔𝚜, 𝙳𝚘𝚌. 𝙸 𝚐𝚞𝚎𝚜𝚜 𝙸'𝚕𝚕 𝚜𝚝𝚒𝚌𝚔 𝚝𝚘 𝚝𝚑𝚒𝚜 𝚝𝚒𝚖𝚎-𝚝𝚛𝚊𝚟𝚎𝚕𝚒𝚗𝚐 𝚌𝚘𝚍𝚎 𝚏𝚘𝚛 𝚗𝚘𝚠!