Skip to content

Comments

add benchmark and JSDoc for isError function#277

Merged
yceffort-naver merged 1 commit intoNaverPayDev:mainfrom
umsungjun:isError-add-jsDoc-benchmark
Jun 9, 2025
Merged

add benchmark and JSDoc for isError function#277
yceffort-naver merged 1 commit intoNaverPayDev:mainfrom
umsungjun:isError-add-jsDoc-benchmark

Conversation

@umsungjun
Copy link
Contributor

  • Added isError.bench.ts for performance comparison with lodash
  • Added JSDoc to isError.ts

스크린샷 2025-05-30 오전 9 51 56

- Added isError.bench.ts for performance comparison with lodash
- Added JSDoc to isError.ts
@umsungjun umsungjun requested a review from a team as a code owner May 30, 2025 00:52
@github-actions
Copy link
Contributor

✅ All utility modules are properly registered in index.ts and package.json exports!

@github-actions
Copy link
Contributor

Benchmark Results

Method Test Performance Comparison hidash ops/sec [email protected] ops/sec
isError src/isError.bench.ts > isError performance hidash is 14.11x faster 81.91 🏆 5.80

Note: Higher operations per second (ops/sec) numbers are better. Each test compares hidash vs lodash implementation.

⚠️ indicates where hidash is slower than lodash.

🏆 indicates the faster implementation.

View Full Benchmark Data
{
  "files": [
    {
      "filepath": "/home/runner/work/hidash/hidash/src/isError.bench.ts",
      "groups": [
        {
          "fullName": "src/isError.bench.ts > isError performance",
          "benchmarks": [
            {
              "id": "1045968056_0_0",
              "name": "hidash",
              "rank": 1,
              "rme": 0.25705527962013436,
              "samples": [],
              "totalTime": 500.5723989999999,
              "min": 12.062013000000093,
              "max": 12.509371999999985,
              "hz": 81.90623390723549,
              "period": 12.209082902439022,
              "mean": 12.209082902439022,
              "variance": 0.009887132891940858,
              "sd": 0.09943406303647084,
              "sem": 0.015528991684274443,
              "df": 40,
              "critical": 2.021,
              "moe": 0.03138409219391865,
              "p75": 12.257167999999979,
              "p99": 12.509371999999985,
              "p995": 12.509371999999985,
              "p999": 12.509371999999985,
              "sampleCount": 41,
              "median": 12.191592000000014
            },
            {
              "id": "1045968056_0_1",
              "name": "lodash",
              "rank": 2,
              "rme": 0.8178714816652398,
              "samples": [],
              "totalTime": 1723.0641220000005,
              "min": 170.8118800000002,
              "max": 177.49126699999988,
              "hz": 5.803614544763876,
              "period": 172.30641220000004,
              "mean": 172.30641220000004,
              "variance": 3.8813946959075563,
              "sd": 1.9701255533360194,
              "sem": 0.623008402504136,
              "df": 9,
              "critical": 2.262,
              "moe": 1.4092450064643558,
              "p75": 172.3994210000003,
              "p99": 177.49126699999988,
              "p995": 177.49126699999988,
              "p999": 177.49126699999988,
              "sampleCount": 10,
              "median": 171.928901
            }
          ]
        }
      ]
    }
  ]
}

Last updated by GitHub Actions

Copy link
Contributor

@yujeong-jeon yujeong-jeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you:) 👍

@yceffort-naver yceffort-naver merged commit 9dac20a into NaverPayDev:main Jun 9, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants