Skip to content

Comments

feat: add benchmark for isNumber function#270

Merged
yceffort-naver merged 1 commit intoNaverPayDev:mainfrom
umsungjun:feat/isNumber-add-benchmark
May 20, 2025
Merged

feat: add benchmark for isNumber function#270
yceffort-naver merged 1 commit intoNaverPayDev:mainfrom
umsungjun:feat/isNumber-add-benchmark

Conversation

@umsungjun
Copy link
Contributor

  • Added isNumber.bench.ts for performance comparison with lodash
스크린샷 2025-05-15 오후 4 46 25

- Added isNumber.bench.ts for performance comparison with lodash
@umsungjun umsungjun requested a review from a team as a code owner May 15, 2025 07:47
@github-actions
Copy link
Contributor

✅ All utility modules are properly registered in index.ts and package.json exports!

@github-actions
Copy link
Contributor

Benchmark Results

Method Test Performance Comparison hidash ops/sec [email protected] ops/sec
isNumber src/isNumber.bench.ts > isNumber performance hidash is 7.61x faster 3057.40 🏆 402.02

Note: Higher operations per second (ops/sec) numbers are better. Each test compares hidash vs lodash implementation.

⚠️ indicates where hidash is slower than lodash.

🏆 indicates the faster implementation.

View Full Benchmark Data
{
  "files": [
    {
      "filepath": "/home/runner/work/hidash/hidash/src/isNumber.bench.ts",
      "groups": [
        {
          "fullName": "src/isNumber.bench.ts > isNumber performance",
          "benchmarks": [
            {
              "id": "-2092632563_0_0",
              "name": "hidash",
              "rank": 1,
              "rme": 0.2951197771411822,
              "samples": [],
              "totalTime": 500.0980150000003,
              "min": 0.3156500000000051,
              "max": 0.6802099999999882,
              "hz": 3057.4006577490595,
              "period": 0.3270752223675607,
              "mean": 0.3270752223675607,
              "variance": 0.00037084058873720845,
              "sd": 0.019257221729450186,
              "sem": 0.0004924814629261078,
              "df": 1528,
              "critical": 1.96,
              "moe": 0.0009652636673351713,
              "p75": 0.3301559999999881,
              "p99": 0.40359300000000076,
              "p995": 0.4315960000000132,
              "p999": 0.6662640000000124,
              "sampleCount": 1529,
              "median": 0.3235139999999319
            },
            {
              "id": "-2092632563_0_1",
              "name": "lodash",
              "rank": 2,
              "rme": 0.3041930515122873,
              "samples": [],
              "totalTime": 502.4620710000012,
              "min": 2.426341000000093,
              "max": 3.0844990000000507,
              "hz": 402.02039449063113,
              "period": 2.487435995049511,
              "mean": 2.487435995049511,
              "variance": 0.0030105208196568338,
              "sd": 0.05486821319905391,
              "sem": 0.0038605140090592527,
              "df": 201,
              "critical": 1.96,
              "moe": 0.0075666074577561354,
              "p75": 2.5010500000000775,
              "p99": 2.648936000000049,
              "p995": 2.6588839999999436,
              "p999": 3.0844990000000507,
              "sampleCount": 202,
              "median": 2.476804500000071
            }
          ]
        }
      ]
    }
  ]
}

Last updated by GitHub Actions

Copy link
Contributor

@yujeong-jeon yujeong-jeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~!

@yceffort-naver yceffort-naver merged commit ec085c6 into NaverPayDev:main May 20, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants